Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update supply_demand.rst #669

Merged
merged 1 commit into from
May 16, 2023
Merged

Update supply_demand.rst #669

merged 1 commit into from
May 16, 2023

Conversation

lilanger
Copy link
Contributor

@lilanger lilanger commented May 16, 2023 •
edited
Loading

Heat pump COP equations signs are wrong: https://pubs.rsc.org/en/content/articlelanding/2012/EE/c2ee22653g
(I guess/hope in the model it is correct)

Closes # (if applicable).

Changes proposed in this Pull Request

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in all of config.default.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv.
  • A release note doc/release_notes.rst is added.

fneum
fneum approved these changes May 16, 2023
View reviewed changes
Copy link
Member

@fneum fneum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Luckily, code is correct. Better this way than the other way around :) Thanks!

@fneum fneum merged commit 2b62c01 into PyPSA:master May 16, 2023
@lilanger
Copy link
Contributor Author

Great! Yes, indeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fneum fneum fneum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lilanger @fneum