Fix bug with underground H2 storage creation #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some small model regions, none of the H2 cavern types specified in the configuration might actually be available, in which case the line `h2_caverns = h2_caverns[cavern_types].sum(axis=1)` throws an error.
|
By the way it looks like the CI failed because the website where the ENSPRESO data is hosted (cidportal.jrc.ec.europa.eu/ftp/jrc-opendata/ENSPRESO/ENSPRESO_BIOMASS.xlsx) is down at the moment, and I can confirm from personal experience that this happens semi-frequently and when it does it's very annoying! Snakemake will be stuck waiting for the website to respond at the time of building the workflow DAG and only fail after a little while. If it would be possible to include the biomass database in the pypsa-eur databundle that would be really nice! (Of course this is not related to this particular PR; if desired I could open an issue about this.) |
fneum
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some small model regions, none of the H2 cavern types specified in the configuration might actually be available, in which case the line
h2_caverns = h2_caverns[cavern_types].sum(axis=1)throws an error.Checklist
envs/environment.yaml.config.default.yaml.doc/configtables/*.csv.doc/release_notes.rstis added.