Add option for carbon capture in integrated steelworks (Sourcery refactored) #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
| if isinstance(item, dict): | ||
| return item[investment_year] | ||
| else: | ||
| return item | ||
| return item[investment_year] if isinstance(item, dict) else item |
There was a problem hiding this comment.
Function get refactored with the following changes:
- Replace if statement with if expression (
assign-if-exp)
scripts/prepare_sector_network.py
Outdated
Comment on lines
418
to
415
| if snakemake.wildcards.clusters[-1:] == "m": | ||
| genmap = busmap_s | ||
| else: | ||
| genmap = clustermaps | ||
|
|
||
| genmap = busmap_s if snakemake.wildcards.clusters[-1:] == "m" else clustermaps |
There was a problem hiding this comment.
Function update_wind_solar_costs refactored with the following changes:
- Replace if statement with if expression (
assign-if-exp)
scripts/prepare_sector_network.py
Outdated
Comment on lines
510
to
505
| to_drop = list(n.buses.query("carrier not in ['AC', 'DC']").carrier.unique()) | ||
| if to_drop: | ||
| if to_drop := list( | ||
| n.buses.query("carrier not in ['AC', 'DC']").carrier.unique() | ||
| ): |
There was a problem hiding this comment.
Function remove_non_electric_buses refactored with the following changes:
- Use named expression to simplify assignment and conditional (
use-named-expression)
Comment on lines
-1237
to
+1233
| augmentation = list( | ||
| if augmentation := list( | ||
| k_edge_augmentation(G, k_edge, avail=complement_edges.values) | ||
| ) | ||
|
|
||
| if augmentation: | ||
| ): |
There was a problem hiding this comment.
Function add_storage_and_grids refactored with the following changes:
- Use named expression to simplify assignment and conditional (
use-named-expression)
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request #719 refactored by Sourcery.
If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
blast-furnace-with-ccbranch, then run:Help us improve this pull request!