Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Env fixes #805

Merged
merged 9 commits into from
Dec 18, 2023
Merged

Env fixes #805

merged 9 commits into from
Dec 18, 2023

Conversation

martacki
Copy link
Member

@martacki martacki commented Dec 18, 2023

Closes # (if applicable).

Changes proposed in this Pull Request

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in all of config.default.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv.
  • A release note doc/release_notes.rst is added.

@martacki martacki marked this pull request as draft December 18, 2023 08:58
@martacki
Copy link
Member Author

thanks @FabianHofmann, for me the workflow finally runs now (provided we also merge PyPSA/PyPSA#806 - not sure though if this is a local problem of mine, because CI is passing now 🎉)

I think the .fillna(0) in simplify_network was an artifact that was fixed when I was trying to trace the clustering problem

@FabianHofmann FabianHofmann marked this pull request as ready for review December 18, 2023 13:30
@FabianHofmann
Copy link
Contributor

great, thanks @martacki

@FabianHofmann FabianHofmann merged commit 179ab43 into master Dec 18, 2023
5 checks passed
@FabianHofmann FabianHofmann deleted the env_fixes branch December 18, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants