Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add technology specific renewable profiles for different planning horizons #859

Closed
wants to merge 3 commits into from

Conversation

p-glaum
Copy link
Contributor

@p-glaum p-glaum commented Jan 11, 2024

Closes # (if applicable).

Changes proposed in this Pull Request

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in all of config.default.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv.
  • A release note doc/release_notes.rst is added.

@p-glaum p-glaum marked this pull request as draft January 11, 2024 16:29
@p-glaum
Copy link
Contributor Author

p-glaum commented Jan 11, 2024

I am not so happy with the build renewable profiles, because this takes rather a long time. Suggestions on how to improve performance here without adding new wildcards are welcome.

@@ -335,6 +346,29 @@
**resource,
)

if year_dependent_techs and foresight != "overnight":
for key, techs in year_dependent_techs.items():
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

year_dependent_techs would always be a dictionary with one entry, right? In this case, it would be better to
remove this for-loop.

Regarding performance, did you check that the number of iterations in this nested for-loop is the desired number? If yes, I don't think there is much you can gain in performance.

Copy link
Contributor Author

@p-glaum p-glaum Jan 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

year_dependent_techs would always be a dictionary with one entry, right? In this case, it would be better to
remove this for-loop.

correct, but the key can change depending whether we consider PV or wind to panel or turbine, respectively

Regarding performance, did you check that the number of iterations in this nested for-loop is the desired number?

yes, it only runs the function func once for every technology

@fneum
Copy link
Member

fneum commented Feb 5, 2024

superseded by #912

@fneum fneum closed this Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants