Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformulate co2 constraint #862

Merged
merged 6 commits into from
Jan 18, 2024
Merged

Reformulate co2 constraint #862

merged 6 commits into from
Jan 18, 2024

Conversation

lisazeyen
Copy link
Contributor

@lisazeyen lisazeyen commented Jan 12, 2024

Closes # (if applicable).

Change CO2 emission constraint for sector coupled models

Instead of using the primary_energyglobal constraint formulation this PR puts a constraint on the last snapshot of the co2 atmosphere bus.

TODO: haven't tested yet if performance improves for overnight scenarios

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in all of config.default.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv.
  • A release note doc/release_notes.rst is added.

@lisazeyen lisazeyen marked this pull request as draft January 18, 2024 10:35
Copy link
Member

@fneum fneum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like charm @lisazeyen!

I double-checked that the objective value and shadow prices are the same.

Performance was about the same for a 100-second model.

@fneum fneum marked this pull request as ready for review January 18, 2024 18:32
@fneum fneum merged commit dd1e07e into master Jan 18, 2024
2 of 5 checks passed
@fneum fneum deleted the reformulate-co2-constraint branch January 18, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants