Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix key_error in validation plots #878

Merged
merged 2 commits into from
Jan 18, 2024

Conversation

Tomkourou
Copy link
Contributor

Closes # (if applicable).

Changes proposed in this Pull Request

Currently, running the validation workflow fails at the plot_validation_electricity_production rule due to a mismatch between historic data keys and the outputs of the pypsa network. The submitted code corrects technology keys for the rule to work out the box.

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in all of config.default.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv.
  • A release note doc/release_notes.rst is added.

Copy link
Member

@fneum fneum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Tomkourou, I don't think we'll maintain the validation plotting in detail and maybe even outsource it from the main PyPSA-Eur repository prospectively.

I'll merge your changes without a detailed review.

@fneum fneum merged commit 6d2f2cc into PyPSA:master Jan 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants