Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't include triple solar potential option by default #891

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

koen-vg
Copy link
Contributor

@koen-vg koen-vg commented Jan 24, 2024

Changes proposed in this Pull Request

A trivial change in default {sector_opts} wildcard. I know that it's very much the intention that users will inform themselves about each wildcard and option and change them to fit their needs. However, defaults do carry some weight, and arguably the solar+p3 option was a sensible default. After a0f43ae, however, this is no longer the case! I would remove the option from the default {sector_opts} wildcard to avoid confusion.

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in all of config.default.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv.
  • A release note doc/release_notes.rst is added.

@fneum fneum merged commit 17d0e16 into PyPSA:master Jan 24, 2024
2 of 5 checks passed
@fneum
Copy link
Member

fneum commented Jan 24, 2024

Agreed, I missed this. Thanks!

@koen-vg
Copy link
Contributor Author

koen-vg commented Jan 24, 2024

Actually I do now see that this was maybe a bit rushed and there are more references to solar+p3 in other configs as well as mock snakemake sections. Would you want me to remove those as well for consistency?

@fneum
Copy link
Member

fneum commented Jan 24, 2024

I can do it, no worries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants