Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare_sector_network: reorder buses for dac components #901

Merged
merged 6 commits into from
Feb 5, 2024

Conversation

FabianHofmann
Copy link
Contributor

Change the order of buses (bus0, bus1, ...) for DAC components to meet the convention of the other components: bus0 refers to the electricity bus (input), bus1 to the heat bus (input), 'bus2' to the CO2 atmosphere bus (input), and bus3 to the CO2 storage bus (output).

Why is this helpful?

For many routines in the pypsa statistics module, a convention where the bus0 points to the location (in order to extract local balances) is assumed. With this change, the location of the DAC facilities is properly processed.

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in all of config.default.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv.
  • A release note doc/release_notes.rst is added.

Copy link
Member

@fneum fneum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is one mistake with the units / efficiencies. Could you double check?

scripts/prepare_sector_network.py Outdated Show resolved Hide resolved
@FabianHofmann
Copy link
Contributor Author

I made a small test case locally, this works as expected.

@fneum fneum enabled auto-merge February 5, 2024 07:50
@fneum fneum disabled auto-merge February 5, 2024 11:19
@fneum fneum merged commit 7e2ad98 into master Feb 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants