Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix index for existing capacities in add_existing_baseyear #992

Closed
wants to merge 1 commit into from
Closed

Fix index for existing capacities in add_existing_baseyear #992

wants to merge 1 commit into from

Conversation

tgi-climact
Copy link
Contributor

When m option is enabled in add_power_capacities_installed_before_baseyear, the referenced index use baseyear in place of current year of installation (grouping_year). This leads to empty inv_ind and issue in the rest of the code.

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in all of config.default.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv.
  • A release note doc/release_notes.rst is added.

@fneum fneum requested a review from lisazeyen April 3, 2024 09:37
@lisazeyen lisazeyen mentioned this pull request Apr 3, 2024
Merged
6 tasks
@lisazeyen
Copy link
Contributor

Just updated with master and merged in PR #1002. Thank you @tgi-climact !

@lisazeyen lisazeyen closed this Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lisazeyen lisazeyen lisazeyen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tgi-climact @lisazeyen