-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Thai W2P #511
Add Thai W2P #511
Conversation
Hello @wannaphong! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-01-07 13:59:28 UTC |
Google colab for test https://colab.research.google.com/drive/1MYc5PztkY26-O1bgRXmh9rShx0GLwFWp?usp=sharing |
Model CardModel Details
Intended Use
Factors
Metrics
Training Data Thai W2P Evaluation Data Thai W2P Quantitative Analyses
Ethical Considerations thai phoneme based on website (wiktionary, Royal Institute et cetera). It may not be the dialect that you use in everyday life. Caveats and Recommendations
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it possible now for the transliterate() function to convert multiple Thai words into their sound representation?
If not, I suggest that it should. Because that's how other engine do. We should keep the types of input and output consistent.
This can be done by tokenized the input first, then do the w2p for each token.
I changed |
…pythainlp into Add-thai-word2phoneme
I think we're good to go. Thanks @wannaphong |
All Thai G2P, Thai W2P, etc. can be converted to the singleton pattern but we can do that later. |
@bact Thank you. |
What does this changes
I add Thai Word-to-Phoneme converter to
pythainlp.transliterate.pronunciate
. It's converter thai word to thai phoneme.GitHub: https://github.com/wannaphong/Thai_W2P
Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.