Add tzdata as a dependency on Windows #841
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this changes
Add
tzdata
as a dependency on Windows, and also some code cleanups inpythainlp.util.data
.What was wrong
pythainlp.util.data
use the standard libraryzoneinfo
, which would uses the system’s time zone data if available, otherwise it would usetzdata
.Time zone data is included on macOS and Linux, but not on Windows, so
tzdata
is required to be installed on Windows, otherwise onimport pythainlp
it would show this error:How this fixes it
Add
tzdata
as a dependency on Windows.Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.