Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #847

Closed
wants to merge 1 commit into from
Closed

Fix typos #847

wants to merge 1 commit into from

Conversation

kianmeng
Copy link

What does this changes

Fix typos found via:

  • codespell -S ./pythainlp/corpus -L etcc,tha,fo,ue,ist,ans
  • typos --format brief

What was wrong

Description of what was the root cause of the issue.

How this fixes it

Description of how the changes fix the issue.

Fixes #...

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Passed code styles and structures

Note that black --line-length=79 will reformat all codes.

  • Passed code linting checks and unit test

Found via:
- `codespell -S ./pythainlp/corpus -L etcc,tha,fo,ue,ist,ans`
- `typos --format brief`
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@pep8speaks
Copy link

Hello @kianmeng! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 186:21: W291 trailing whitespace
Line 323:101: E501 line too long (155 > 100 characters)

Line 54:101: E501 line too long (165 > 100 characters)
Line 63:101: E501 line too long (141 > 100 characters)

Line 284:9: W503 line break before binary operator
Line 291:9: W503 line break before binary operator
Line 298:9: W503 line break before binary operator

Line 26:101: E501 line too long (148 > 100 characters)

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@BLKSerene
Copy link
Contributor

I suppose that this PR is largely overlapping with #845... Maybe you could review and leave comments on that one and close this one?

@coveralls
Copy link

Coverage Status

coverage: 0.0%. remained the same when pulling 24f2935 on kianmeng:fix-typos into 73b17e3 on PyThaiNLP:dev.

@kianmeng
Copy link
Author

@BLKSerene Perhaps you can take these two commands and apply in your PR?

codespell -S ./pythainlp/corpus -L etcc,tha,fo,ue,ist,ans
typos --format brief

Sounds good? If so, I will close this PR then.

@BLKSerene
Copy link
Contributor

@BLKSerene Perhaps you can take these two commands and apply in your PR?

codespell -S ./pythainlp/corpus -L etcc,tha,fo,ue,ist,ans
typos --format brief

Sounds good? If so, I will close this PR then.

@kianmeng I've already updated my PR to fix the typos found in this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants