Fix coref return type and add fallback #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- coref: Fix `FastCoref.predict()` return type - coref: Make sure that `coreference_resolution()` returns something valid, even if it failed to get a model - classify: was `cls`, rename for naming consistency - `pythainlp.cls` is still accessible for backward compatibility (with deprecated warning) - General code formatting and import sorting - Add ruff config
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Hello @bact! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2023-12-07 02:05:20 UTC |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FastCoref.predict()return typecoreference_resolution()returns something valid, even if it failed to get a modelcls, rename for naming consistency -pythainlp.clsis still accessible for backward compatibility (with deprecated warning)Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.