Fix collate() to consider tonemark in ordering #926
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this changes
Update Thai tone ordering sorted from #558
What was wrong
pythainlp.util.collate()
results a wrong ordering,from
collate
function expect.but before my pull request is
How this fixes it
Fixed it by use
search()
method fromPattern
class inre
module. Then concat Thai tone with current lead vowel strings. atfrom
to
Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.
P.S. some of unit test on
collate
function is pass but other unitest of normalize,maiyamok
not pass