Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix maiyamok() that expanding the wrong word #962

Merged
merged 8 commits into from
Nov 2, 2024
Merged

Fix maiyamok() that expanding the wrong word #962

merged 8 commits into from
Nov 2, 2024

Conversation

bact
Copy link
Member

@bact bact commented Nov 1, 2024 •
edited
Loading

Rewrite expand_maiyamok()

  • break down maiyamok inside a token first
  • then count maiyamok from the back until it reach a word to be repeated

Fix #955 - passed all tests

@bact bact closed this Nov 1, 2024
@bact bact reopened this Nov 2, 2024
@bact bact added the bug bugs in the library label Nov 2, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 2, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@bact bact merged commit dd1b3f8 into PyThaiNLP:dev Nov 2, 2024
24 checks passed
@bact bact deleted the fix-expand-maiyamok branch November 2, 2024 06:52
@bact bact changed the title Fix expand maiyamok Fix maiyamok() that expanding the wrong word Nov 2, 2024
@bact bact mentioned this pull request Nov 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug bugs in the library
Projects
PyThaiNLP
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: maiyamok repeats the wrong word
1 participant
@bact