Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings and types #978

Merged
merged 5 commits into from
Nov 3, 2024
Merged

Fix warnings and types #978

merged 5 commits into from
Nov 3, 2024

Conversation

bact
Copy link
Member

@bact bact commented Nov 3, 2024

  • Also add tests.core.test_generate

@bact bact added refactoring a technical improvement which does not add any new features or change existing features. tests Unit test, code coverage, test case labels Nov 3, 2024
@bact
dict init should be after the get_corpus check
9ed5207 
unless it will never try the second time
@coveralls
Copy link

coveralls commented Nov 3, 2024 •
edited
Loading

Coverage Status

coverage: 51.837% (+1.5%) from 50.318%
when pulling 8409f8f on bact:add-generate-test
into cf3e625 on PyThaiNLP:dev.

@bact bact merged commit ed83a18 into PyThaiNLP:dev Nov 3, 2024
19 of 21 checks passed
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 3, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
4 Security Hotspots

See analysis details on SonarCloud

@bact bact deleted the add-generate-test branch November 3, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
refactoring a technical improvement which does not add any new features or change existing features. tests Unit test, code coverage, test case
Projects
PyThaiNLP
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bact @coveralls