Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Efficient Detection Net #31

Closed

Conversation

danielkurniadi
Copy link

@danielkurniadi danielkurniadi commented Jun 1, 2020

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Implement #1: #1

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@pep8speaks
Copy link

pep8speaks commented Jun 1, 2020

Hello @iqDF! Thanks for updating this PR.

Line 42:121: E501 line too long (128 > 120 characters)
Line 43:1: W293 blank line contains whitespace
Line 46:1: W293 blank line contains whitespace
Line 74:21: E128 continuation line under-indented for visual indent
Line 86:1: W293 blank line contains whitespace
Line 96:1: W293 blank line contains whitespace
Line 101:27: E261 at least two spaces before inline comment
Line 102:1: W293 blank line contains whitespace
Line 108:55: E226 missing whitespace around arithmetic operator
Line 109:44: E261 at least two spaces before inline comment
Line 111:1: W293 blank line contains whitespace
Line 115:1: W293 blank line contains whitespace
Line 122:80: W291 trailing whitespace
Line 123:62: W291 trailing whitespace

Comment last updated at 2020-06-28 03:40:51 UTC

@danielkurniadi
Copy link
Author

@pep8speaks Will fix Pep8 linting in the next commit.

@Borda Borda force-pushed the master branch 2 times, most recently from 798090b to 3879c3a Compare June 2, 2020 12:40
@williamFalcon williamFalcon reopened this Jun 4, 2020
@williamFalcon
Copy link
Contributor

@iqDF fixed the conflicts!
this is super cool. let's get this merged

@williamFalcon
Copy link
Contributor

@iqDF don't worry about builds or any of that right now. let's just get the model working (confirmed). we can work out the build issues later

@danielkurniadi
Copy link
Author

@williamFalcon ok cool. will continue the work.

@mergify
Copy link
Contributor

mergify bot commented Jun 20, 2020

This pull request is now in conflict... :(

@williamFalcon
Copy link
Contributor

@iqDF ok, we now merged a lot of the building blocks and structures.
Take a look at some of the self-supervised examples for the standard conventions :)

looking forward to adding!

@williamFalcon
Copy link
Contributor

@iqDF we finally got the v1 of bolts ready with tests and docs. Let's continue this implementation?
I noticed there is a timm dependency? mind implementing these things directly since we want to keep bolts lightweight?

@Borda Borda added the enhancement New feature or request label Jul 3, 2020
@stale
Copy link

stale bot commented Oct 13, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the won't fix This will not be worked on label Oct 13, 2020
@stale stale bot closed this Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request won't fix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants