Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

latest restore func metrics #3949

Merged
merged 2 commits into from
Oct 7, 2020
Merged

Conversation

Borda
Copy link
Member

@Borda Borda commented Oct 7, 2020

What does this PR do?

Fixes #3943

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@pep8speaks
Copy link

pep8speaks commented Oct 7, 2020

Hello @Borda! Thanks for updating this PR.

Line 176:121: E501 line too long (127 > 120 characters)

Comment last updated at 2020-10-07 17:51:06 UTC

@Borda Borda force-pushed the refactor/restore-func-metrics branch from cee7457 to e2891d9 Compare October 7, 2020 17:47
@Borda Borda marked this pull request as ready for review October 7, 2020 17:47
@mergify mergify bot requested a review from a team October 7, 2020 17:51
@Borda Borda mentioned this pull request Oct 7, 2020
7 tasks
@Borda Borda requested a review from williamFalcon October 7, 2020 18:19
@codecov
Copy link

codecov bot commented Oct 7, 2020

Codecov Report

Merging #3949 into master will increase coverage by 4%.
The diff coverage is 94%.

@@           Coverage Diff           @@
##           master   #3949    +/-   ##
=======================================
+ Coverage      88%     92%    +4%     
=======================================
  Files         108     109     +1     
  Lines        7745    7830    +85     
=======================================
+ Hits         6843    7217   +374     
+ Misses        902     613   -289     

@williamFalcon williamFalcon merged commit 616fe82 into master Oct 7, 2020
@Borda Borda deleted the refactor/restore-func-metrics branch October 7, 2020 19:06
@Borda Borda added this to the 0.10.0 milestone Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants