-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix plateau scheduler stepping on incomplete epoch #8861
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8861 +/- ##
=======================================
- Coverage 93% 89% -4%
=======================================
Files 169 169
Lines 14078 14079 +1
=======================================
- Hits 13052 12475 -577
- Misses 1026 1604 +578 |
awaelchli
commented
Aug 11, 2021
awaelchli
commented
Aug 11, 2021
awaelchli
requested review from
Borda,
carmocca,
justusschock,
kaushikb11,
SeanNaren,
tchaton and
williamFalcon
as code owners
August 11, 2021 23:07
carmocca
approved these changes
Aug 11, 2021
ananthsub
approved these changes
Aug 12, 2021
Borda
approved these changes
Aug 12, 2021
four4fish
pushed a commit
to four4fish/pytorch-lightning
that referenced
this pull request
Aug 16, 2021
kaushikb11
pushed a commit
to kaushikb11/pytorch-lightning
that referenced
this pull request
Aug 18, 2021
lexierule
pushed a commit
that referenced
this pull request
Aug 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #8839
Added test FAILS without the fix applied.
This fixes an issue with the training loop trying to step an epoch level scheduler when the epoch is incomplete. This happens in the case when e.g. we specify
Trainer(max_steps=x)
where x < one epoch. This usually does not matter, but is problematic when the scheduler monitors a metric from a validation epoch, which does not actually run if we finish training early.Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃