-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed max_steps
default from None to -1
#9460
Changed max_steps
default from None to -1
#9460
Conversation
ab74d48
to
55c87fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! Thanks for your work ❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work ! Almost there.
1bf50d7
to
a8662f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT ! Great work !
Codecov Report
@@ Coverage Diff @@
## master #9460 +/- ##
======================================
Coverage 89% 89%
======================================
Files 182 182
Lines 16157 16153 -4
======================================
+ Hits 14322 14327 +5
+ Misses 1835 1826 -9 |
…to `-1` (Lightning-AI#9460) Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com> Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> Co-authored-by: thomas chaton <thomas@grid.ai> Co-authored-by: rohitgr7 <rohitgr1998@gmail.com>
Summary: PR: Lightning-AI/pytorch-lightning#9460 Introduced by diff D31918136 Reviewed By: tangbinh Differential Revision: D34804291 fbshipit-source-id: c125f5618e0e4b53975a7d8c1b58ef7f0750afa4
max_steps
default from None to -1
What does this PR do?
This PR addresses this comment. It changes
max_steps
to default to-1
and no longer allowsNone
to be specified formax_steps
.Fixes #8818
The new combinations for
max_epochs
andmax_steps
are:Only allow
None
for themax_epochs
parameter and in the case (13), otherwise convert it to-1
, this way we have:max_epochs
max_steps
Does your PR introduce any breaking changes? If yes, please list them.
Yes. You can no longer specify
max_steps = None
.Not sure what needs to be done w/ regards to this.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Always