Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reorganize message component guides and localization guide #62

Merged
merged 4 commits into from
Mar 24, 2022

Conversation

EmmmaTech
Copy link
Contributor

@EmmmaTech EmmmaTech commented Mar 23, 2022

This problem didn't spot my eye until after I merged #59. I should probably pay more attention next time.

FYI: the new placement of the modal guide is not final.

@vercel
Copy link

vercel bot commented Mar 23, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pycord-development/guide/DBWLFZDakDjoaha9U6R75CkoLPZR
✅ Preview: https://guide-git-fix-interaction-guide-foldering-pycord-development.vercel.app

@VincentRPS
Copy link
Member

I don’t think we need a separated category for app commands imo

@EmmmaTech
Copy link
Contributor Author

I think it's reasonable. Plus, message components are in their own folder, so it wouldn't really make any sense to just leave Application Command guides in the main folder.

@VincentRPS
Copy link
Member

I think it's reasonable. Plus, message components are in their own folder, so it wouldn't really make any sense to just leave Application Command guides in the main folder.

But message components and app commands are nothing alike

@EmmmaTech
Copy link
Contributor Author

I think it's reasonable. Plus, message components are in their own folder, so it wouldn't really make any sense to just leave Application Command guides in the main folder.

But message components and app commands are nothing alike

Ummmmm... what does that have to do with this discussion? I'm trying to say since Message Components have their own folder (and you aren't complaining), why not give Application Commands their own folder?

@EmmmaTech EmmmaTech changed the title chore: reorganized message component guides and localization guide chore: reorganize message component guides and localization guide Mar 23, 2022
@vercel vercel bot temporarily deployed to Preview March 23, 2022 20:35 Inactive
@vercel vercel bot temporarily deployed to Preview March 24, 2022 20:41 Inactive
@EmmmaTech EmmmaTech merged commit 395af4c into master Mar 24, 2022
@EmmmaTech EmmmaTech deleted the fix-interaction-guide-foldering branch March 25, 2022 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants