fix: premium buttons and entitlement iterator #2490

tibue99 · 2024-07-01T16:10:52Z

Summary

This PR fixes some issues with monetization.

Premium buttons do not work with a custom ID, I disabled the auto-generated custom_id for premium buttons
bot.fetch_entitlements() did not work when certain parameters were not set
The exclude_ended attribute threw an error, because yarl does not support boolean params. I don't know how to fix that, so I just set it to None for now. Perhaps @plun1331 can help

I have tested the changes with a monetized Discord bot.

Edit: This PR now renames client.fetch_entitlements to client.entitlements.

Information

This PR fixes an issue.
This PR adds something new (e.g. new method or parameters).
This PR is a breaking change (e.g. methods or parameters removed/renamed).
This PR is not a code change (e.g. documentation, README, typehinting,
examples, ...).

Checklist

I have searched the open pull requests for duplicates.
If code changes were made then they have been tested.
- I have updated the documentation to reflect the changes.
If type: ignore comments were used, a comment is also left explaining why.
I have updated the changelog to include these changes.

plun1331 · 2024-07-01T16:13:02Z

The exclude_ended attribute threw an error, because yarl does not support boolean params. I don't know how to fix that, so I just set it to None for now. Perhaps @plun1331 can help

Casting it to a string in the http method should be good enough

Edit: other methods have cast it to int

discord/iterators.py

NeloBlivion

While we're here, the definition of fetch_entitlements should be rethought:

As it returns an Iterator, it should NOT be an async function (matching history, audit_logs, reaction users etc.)
In that vein, to match said functions it should ideally be renamed to just entitlements to follow standard iterator usage:

async for e in client.entitlements():
   ...

entitlements = await user.entitlements().flatten()

Lulalaby · 2024-07-01T21:52:19Z

Timo for the win. Thank you

Dorukyum

Changelog (this is a breaking change)

discord/client.py

Dorukyum · 2024-07-02T22:43:58Z

Have the latest changes been tested?

tibue99 · 2024-07-02T23:06:05Z

Have the latest changes been tested?

I have tested client.entitlements() in production, but I have not tested the user/guild methods separately.

Lulalaby

LGTM

Solved, waiting for testing

CHANGELOG.md

Signed-off-by: plun1331 <plun1331@gmail.com>

* chore(deps-dev): update pylint requirement from ~=3.2.3 to ~=3.2.4 (Pycord-Development#2482) Updates the requirements on [pylint](https://github.com/pylint-dev/pylint) to permit the latest version. - [Release notes](https://github.com/pylint-dev/pylint/releases) - [Commits](pylint-dev/pylint@v3.2.3...v3.2.4) --- updated-dependencies: - dependency-name: pylint dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * docs: limits on integer and number option types (Pycord-Development#2462) Signed-off-by: JustaSqu1d <89910983+JustaSqu1d@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com> Co-authored-by: Lala Sabathil <lala@pycord.dev> * feat: update monetization (Pycord-Development#2438) * fix: always cast PartialMessage(able) IDs to int (Pycord-Development#2406) * force partial IDs to int * changelog * Update CHANGELOG.md Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com> Signed-off-by: UK <41271523+NeloBlivion@users.noreply.github.com> * different fix * adjust changelog --------- Signed-off-by: UK <41271523+NeloBlivion@users.noreply.github.com> Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com> * feat: add Attachment.title (Pycord-Development#2486) * feat: implement MemberFlags (Pycord-Development#2489) * feat: implement RoleFlags (Pycord-Development#2487) * implement roleflags * style(pre-commit): auto fixes from pre-commit.com hooks * cl * style(pre-commit): auto fixes from pre-commit.com hooks * Update discord/flags.py Signed-off-by: plun1331 <plun1331@gmail.com> * Update CHANGELOG.md Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com> Signed-off-by: UK <41271523+NeloBlivion@users.noreply.github.com> * fix docs * again? * better formatting * flags.py aktualisieren Signed-off-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com> * test formatting fix * resolve conflicts * revert --------- Signed-off-by: plun1331 <plun1331@gmail.com> Signed-off-by: UK <41271523+NeloBlivion@users.noreply.github.com> Signed-off-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: plun1331 <plun1331@gmail.com> Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com> * fix: enum option issues (Pycord-Development#2463) * patch enums * cl * document enum choice/autocomplete behaviour * Update discord/commands/options.py Co-authored-by: Icebluewolf <44532864+Icebluewolf@users.noreply.github.com> Signed-off-by: UK <41271523+NeloBlivion@users.noreply.github.com> * clarify docstring and warn * style(pre-commit): auto fixes from pre-commit.com hooks * import * style(pre-commit): auto fixes from pre-commit.com hooks --------- Signed-off-by: UK <41271523+NeloBlivion@users.noreply.github.com> Co-authored-by: Icebluewolf <44532864+Icebluewolf@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Lala Sabathil <lala@pycord.dev> * feat: implement MessageCall (Pycord-Development#2488) * implement messagecalls * style(pre-commit): auto fixes from pre-commit.com hooks * adjust design + cl * style(pre-commit): auto fixes from pre-commit.com hooks * __all__ * message.py aktualisieren Signed-off-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com> --------- Signed-off-by: UK <41271523+NeloBlivion@users.noreply.github.com> Signed-off-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com> * chore(deps-dev): update pylint requirement from ~=3.2.4 to ~=3.2.5 (Pycord-Development#2484) Updates the requirements on [pylint](https://github.com/pylint-dev/pylint) to permit the latest version. - [Release notes](https://github.com/pylint-dev/pylint/releases) - [Commits](pylint-dev/pylint@v3.2.4...v3.2.5) --- updated-dependencies: - dependency-name: pylint dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: remove_application_command missing case (Pycord-Development#2480) * fix: remove_application_command has wrong logic * changelog * fix: premium buttons and entitlement iterator (Pycord-Development#2490) * Fix premium buttons * Fix EntitlementIterator call * Test yarl bool * Add TODO * style(pre-commit): auto fixes from pre-commit.com hooks * Cast `exclude_ended` to int * Fix cast * Adjust fetch_entitlements to match other iterators * Add changelog --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * fix: update audit log filtering & sorting (Pycord-Development#2371) * fix: either i'm high and it won't work, or i'm god and this works * Update iterators.py * Update iterators.py Signed-off-by: Lala Sabathil <lala@pycord.dev> * chore: clean code Signed-off-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com> * chore: add changelog entry Signed-off-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com> * chore: add changelog entry Signed-off-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com> * style(pre-commit): auto fixes from pre-commit.com hooks * Update guild.py Signed-off-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com> --------- Signed-off-by: Lala Sabathil <lala@pycord.dev> Signed-off-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com> Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * chore: remove `vanity_code` from `Guild.edit` (Pycord-Development#2491) chore: remove vanity_code from Guild.edit * fix: further address audit log issues (Pycord-Development#2492) * chore: improve nesting error message (Pycord-Development#2275) * chore: improve subgroup limit error message * Changelog * style(pre-commit): auto fixes from pre-commit.com hooks * Update discord/commands/core.py Co-authored-by: Lala Sabathil <aiko@aitsys.dev> Signed-off-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com> * Update core.py * style(pre-commit): auto fixes from pre-commit.com hooks * Update CHANGELOG.md * style(pre-commit): auto fixes from pre-commit.com hooks --------- Signed-off-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Lala Sabathil <aiko@aitsys.dev> * docs: add missing attributes to UserCommand and MessageCommand (Pycord-Development#2494) * chore: update readme and changelog (Pycord-Development#2493) * chore: fix incorrect pull ID * chore: update key features * chore: add dot * chore: add 2.6 header * chore: move the 2.6 header * chore: add complete changelog link * fix changelog position of Pycord-Development#2275 * Update CHANGELOG.md --------- Co-authored-by: Lala Sabathil <aiko@aitsys.dev> * docs: add docs for Interaction.entitlements (Pycord-Development#2495) Signed-off-by: plun1331 <plun1331@gmail.com> * fix: Rename 'cover' to 'image' in relation to ScheduledEvent (Pycord-Development#2496) * fix: Rename 'cover' to 'image' in relation to ScheduledEvent * docs: Typo * style(pre-commit): auto fixes from pre-commit.com hooks --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * chore(deps-dev): update coverage requirement from ~=7.5 to ~=7.6 (Pycord-Development#2497) Updates the requirements on [coverage](https://github.com/nedbat/coveragepy) to permit the latest version. - [Release notes](https://github.com/nedbat/coveragepy/releases) - [Changelog](https://github.com/nedbat/coveragepy/blob/master/CHANGES.rst) - [Commits](nedbat/coveragepy@7.5.0...7.6.0) --- updated-dependencies: - dependency-name: coverage dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: inverted type hints in `CheckAnyFailure` (Pycord-Development#2502) * chore(deps-dev): update mypy requirement from ~=1.10.1 to ~=1.11.0 (Pycord-Development#2503) Updates the requirements on [mypy](https://github.com/python/mypy) to permit the latest version. - [Changelog](https://github.com/python/mypy/blob/master/CHANGELOG.md) - [Commits](python/mypy@v1.10.1...v1.11) --- updated-dependencies: - dependency-name: mypy dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): update pylint requirement from ~=3.2.5 to ~=3.2.6 (Pycord-Development#2505) Updates the requirements on [pylint](https://github.com/pylint-dev/pylint) to permit the latest version. - [Release notes](https://github.com/pylint-dev/pylint/releases) - [Commits](pylint-dev/pylint@v3.2.5...v3.2.6) --- updated-dependencies: - dependency-name: pylint dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): update pytest requirement from ~=8.2.2 to ~=8.3.1 (Pycord-Development#2506) Updates the requirements on [pytest](https://github.com/pytest-dev/pytest) to permit the latest version. - [Release notes](https://github.com/pytest-dev/pytest/releases) - [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst) - [Commits](pytest-dev/pytest@8.2.2...8.3.1) --- updated-dependencies: - dependency-name: pytest dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * docs: minor `InputText` formatting issues (Pycord-Development#2507) * chore(deps-dev): update pytest requirement from ~=8.3.1 to ~=8.3.2 (Pycord-Development#2508) Updates the requirements on [pytest](https://github.com/pytest-dev/pytest) to permit the latest version. - [Release notes](https://github.com/pytest-dev/pytest/releases) - [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst) - [Commits](pytest-dev/pytest@8.3.1...8.3.2) --- updated-dependencies: - dependency-name: pytest dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: avoid premature garbage collection of tasks (Pycord-Development#2510) * avoid premature garbage collection of Client tasks * style(pre-commit): auto fixes from pre-commit.com hooks * remove typehint (pre-commit makes it non compatible with older python) * style(pre-commit): auto fixes from pre-commit.com hooks --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * fix: 📝 Improve wording in `option` decorator slightly (Pycord-Development#2512) :memo: Improve wording in `option` decorator slightly * chore(deps-dev): update mypy requirement from ~=1.11.0 to ~=1.11.1 (Pycord-Development#2511) Updates the requirements on [mypy](https://github.com/python/mypy) to permit the latest version. - [Changelog](https://github.com/python/mypy/blob/master/CHANGELOG.md) - [Commits](python/mypy@v1.11...v1.11.1) --- updated-dependencies: - dependency-name: mypy dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump flake8 from 7.1.0 to 7.1.1 (Pycord-Development#2518) Bumps [flake8](https://github.com/pycqa/flake8) from 7.1.0 to 7.1.1. - [Commits](PyCQA/flake8@7.1.0...7.1.1) --- updated-dependencies: - dependency-name: flake8 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(python)!: remove support for python 3.8 (Pycord-Development#2521) * chore(python)!: remove support for python 3.8 Needed for new docs + python 3.8 is gonna be EOL by october * fix: changelog warning Signed-off-by: Lala Sabathil <lala@pycord.dev> --------- Signed-off-by: Lala Sabathil <lala@pycord.dev> * feat: multilingual docs (Pycord-Development#2522) * New Crowdin Translations (Pycord-Development#2523) New Crowdin translations by GitHub Action Co-authored-by: Crowdin Bot <support+bot@crowdin.com> * [ci skip] fix(actions): crowdin commit message Signed-off-by: Lala Sabathil <lala@pycord.dev> * [ci skip] fix(actions): auto approve for crowdin, bot might use other name Signed-off-by: Lala Sabathil <lala@pycord.dev> * fix(actions): crowdin upload only per command in commit message or dispatch Signed-off-by: Lala Sabathil <lala@pycord.dev> * [ci skip] Update readme to include link to crowdin Signed-off-by: Lala Sabathil <lala@pycord.dev> * [ci skip] fix(actions): fix typos .-. Signed-off-by: Lala Sabathil <lala@pycord.dev> * fix(docs): fix translation language codes (Pycord-Development#2524) * Revert "fix(docs): fix translation language codes (Pycord-Development#2524)" This reverts commit 13e1b43. * [ci skip] fix: fix codeowners typo Signed-off-by: Lala Sabathil <lala@pycord.dev> * [ci skip] fix(actions): another code owner fix Signed-off-by: Lala Sabathil <lala@pycord.dev> * fix(actions): missing lang code fix (Pycord-Development#2525) * Reapply "fix(docs): fix translation language codes (Pycord-Development#2524)" This reverts commit 00c2091. * fix(actions): missing lang code fix * style(pre-commit): auto fixes from pre-commit.com hooks --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> !crowdin upload * fix(actions): add rusian !crowdin upload * docs: Update localizations from Crowdin (Pycord-Development#2526) Co-authored-by: Crowdin Bot <support+bot@crowdin.com> * docs: fix hyphen-related grammar (Pycord-Development#2527) !crowdin upload * feat: implement `Guild.fetch_role` (Pycord-Development#2528) * feat: implement `Guild.fetch_role` * style(pre-commit): auto fixes from pre-commit.com hooks * docs: add changelog entry --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> !crowdin update * fix(docs): fix encoding? tf !crowdin upload * fix(actions): try to fix docs action * fix: sync en base translation * fix(docs): fix speed breaker !crowdin upload * chore: do something precommit (Pycord-Development#2530) * chore: do something precommit * style(pre-commit): auto fixes from pre-commit.com hooks --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * docs: Update localizations from Crowdin (Pycord-Development#2531) Co-authored-by: Crowdin Bot <support+bot@crowdin.com> * docs: Update localizations from Crowdin (Pycord-Development#2533) Co-authored-by: Crowdin Bot <support+bot@crowdin.com> * fic(actions): let actions run on dispatch * fic(actions): manually dispatch workflows * fix(actions): manually run pr checks * chore(actions): auto approve * [ci skip] chore(actions): delete branch automatically * [ci skip] fix(actions): meow * Update docs-localization-download.yml * [ci skip] fix(actions): shush action * [ci skip] fix(actions): i hate it here * [ci skip] fix(actions): refresh pull * docs: Update localizations from Crowdin (Pycord-Development#2539) * docs: Update localizations from Crowdin * style(pre-commit): auto fixes from pre-commit.com hooks --------- Co-authored-by: Crowdin Bot <support+bot@crowdin.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * fix(actions): fix * docs: Update localizations from Crowdin (Pycord-Development#2540) * docs: Update localizations from Crowdin * style(pre-commit): auto fixes from pre-commit.com hooks --------- Co-authored-by: Crowdin Bot <support+bot@crowdin.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * [ci skip] fix(actions): fix ref * docs: Update localizations from Crowdin (Pycord-Development#2541) Co-authored-by: Crowdin Bot <support+bot@crowdin.com> * docs: Update localizations from Crowdin (Pycord-Development#2542) Co-authored-by: Crowdin Bot <support+bot@crowdin.com> * docs: Update localizations from Crowdin (Pycord-Development#2544) Co-authored-by: Crowdin Bot <support+bot@crowdin.com> * docs: Update localizations from Crowdin (Pycord-Development#2545) Co-authored-by: Crowdin Bot <support+bot@crowdin.com> * fix(actions): fix crowdin action, use bot to create pr * fix(actions): fix crowdin action, use bot to create pr * docs: Update localizations from Crowdin (Pycord-Development#2546) * docs: Update localizations from Crowdin * style(pre-commit): auto fixes from pre-commit.com hooks --------- Co-authored-by: Crowdin Bot <support+bot@crowdin.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * [ci skip] chore(actions): update description * chore(actions)!: rework actions (Pycord-Development#2547) * Delete codeql.yml * Create codeql.yml Signed-off-by: Lala Sabathil <lala@pycord.dev> * [ci skip] fix: update codeowners * fix(actions): fix actions? * fix(actions): fix actions! * fix(actions): finer actions * [ci skip] chore: update dependabot.yml - We have grouped updates now - Updates will only be checked weekly, to not spam Signed-off-by: Lala Sabathil <lala@pycord.dev> * [ci skip] fix: depandabot config fix Signed-off-by: Lala Sabathil <lala@pycord.dev> * chore: Update README.rst Signed-off-by: Lala Sabathil <lala@pycord.dev> * fix(actions): Action scheduling & path check for localization upload - rescheduled codeql to sunday 00:00 - scheduled docs upload to monday 00:00 * [ci skip] chore: update readme Signed-off-by: Lala Sabathil <lala@pycord.dev> * [ci skip] fix: fix readme Signed-off-by: Lala Sabathil <lala@pycord.dev> * feat: release actions and other changes * chore(actions): move sec check to action * chore(actions): Update dependabot.yml Signed-off-by: Lala Sabathil <lala@pycord.dev> * ci(deps): bump pycord-development/execute-whitelist-action from 1.0.5 to 1.0.6 in the patch-version-bumps group (Pycord-Development#2552) ci(deps): bump pycord-development/execute-whitelist-action Bumps the patch-version-bumps group with 1 update: [pycord-development/execute-whitelist-action](https://github.com/pycord-development/execute-whitelist-action). Updates `pycord-development/execute-whitelist-action` from 1.0.5 to 1.0.6 - [Release notes](https://github.com/pycord-development/execute-whitelist-action/releases) - [Commits](Pycord-Development/execute-whitelist-action@v1.0.5...v1.0.6) --- updated-dependencies: - dependency-name: pycord-development/execute-whitelist-action dependency-type: direct:production update-type: version-update:semver-patch dependency-group: patch-version-bumps ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [ci skip] fix(deps-actions): update whitelist action Signed-off-by: Lala Sabathil <lala@pycord.dev> * feat(actions): seperate rdt localization build trigger through gha * fix(docs): fix linkcheck issues * [ci skip] fix: fix linkcheck again * fix(releases): fix release builds & add new release system * fix: fix eol issue * fix: empty commit (Pycord-Development#2553) * empty commit * style(pre-commit): auto fixes from pre-commit.com hooks --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * fix(actions): use marketplace action Signed-off-by: Lala Sabathil <lala@pycord.dev> * fix(actions): re-add docs and discord step * [ci skip] fix: add logo Signed-off-by: Lala Sabathil <aiko@aitsys.dev> * [ci skip] fix: replace with repo image Signed-off-by: Lala Sabathil <lala@pycord.dev> * docs: Update localizations from Crowdin (Pycord-Development#2559) Co-authored-by: Crowdin Bot <support+bot@crowdin.com> * docs: Update localizations from Crowdin (Pycord-Development#2560) Co-authored-by: Crowdin Bot <support+bot@crowdin.com> * chore(deps-dev): update mypy requirement from ~=1.11.1 to ~=1.11.2 in the major-version-bumps group (Pycord-Development#2562) chore(deps-dev): update mypy requirement Updates the requirements on [mypy](https://github.com/python/mypy) to permit the latest version. Updates `mypy` to 1.11.2 - [Changelog](https://github.com/python/mypy/blob/master/CHANGELOG.md) - [Commits](python/mypy@v1.11.1...v1.11.2) --- updated-dependencies: - dependency-name: mypy dependency-type: direct:development dependency-group: major-version-bumps ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * ci(deps): bump ribtoks/tdg-github-action from 0.4.11.pre.beta to 0.4.12.pre.beta in the patch-version-bumps group (Pycord-Development#2563) ci(deps): bump ribtoks/tdg-github-action Bumps the patch-version-bumps group with 1 update: [ribtoks/tdg-github-action](https://github.com/ribtoks/tdg-github-action). Updates `ribtoks/tdg-github-action` from 0.4.11.pre.beta to 0.4.12.pre.beta - [Release notes](https://github.com/ribtoks/tdg-github-action/releases) - [Commits](ribtoks/tdg-github-action@v0.4.11-beta...v0.4.12-beta) --- updated-dependencies: - dependency-name: ribtoks/tdg-github-action dependency-type: direct:production update-type: version-update:semver-patch dependency-group: patch-version-bumps ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: EntitlementIterator behavior and type-hinting (Pycord-Development#2555) * fix: EntitlementIterator behaviour and type-hinting * style(pre-commit): auto fixes from pre-commit.com hooks * simplify if's * add changelog entry * style(pre-commit): auto fixes from pre-commit.com hooks * revert missclick --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Lala Sabathil <lala@pycord.dev> * feat: Member.display_banner (Pycord-Development#2556) Signed-off-by: Matty Widdop <18513864+MattyTheHacker@users.noreply.github.com> Signed-off-by: Lala Sabathil <aiko@aitsys.dev> Signed-off-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Lala Sabathil <aiko@aitsys.dev> Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com> Co-authored-by: Lala Sabathil <lala@pycord.dev> Co-authored-by: YoggieS <61660055+yoggys@users.noreply.github.com> Co-authored-by: plun1331 <plun1331@gmail.com> * fix: Missing slots attributes, wrong variable type, duplicate http methods (Pycord-Development#2500) * remove duplicates, fix unused parameter * polls state storage typehint fix * fix RawReactionClearEmojiEvent __slots__ * fix RawMessagePollVoteEvent __slots__ * fix ForumChannel.default_sort_order type the value were actually int instead of SortOrder enum * style(pre-commit): auto fixes from pre-commit.com hooks * changelog * style(pre-commit): auto fixes from pre-commit.com hooks * Update CHANGELOG.md Co-authored-by: JustaSqu1d <89910983+JustaSqu1d@users.noreply.github.com> Signed-off-by: Readeem <99687127+Readeem@users.noreply.github.com> * Update CHANGELOG.md Co-authored-by: JustaSqu1d <89910983+JustaSqu1d@users.noreply.github.com> Signed-off-by: Readeem <99687127+Readeem@users.noreply.github.com> * Update CHANGELOG.md Co-authored-by: JustaSqu1d <89910983+JustaSqu1d@users.noreply.github.com> Signed-off-by: Readeem <99687127+Readeem@users.noreply.github.com> * style(pre-commit): auto fixes from pre-commit.com hooks * style(pre-commit): auto fixes from pre-commit.com hooks * Apply suggestions from code review Signed-off-by: plun1331 <plun1331@gmail.com> * style(pre-commit): auto fixes from pre-commit.com hooks --------- Signed-off-by: Readeem <99687127+Readeem@users.noreply.github.com> Signed-off-by: Lala Sabathil <lala@pycord.dev> Signed-off-by: plun1331 <plun1331@gmail.com> Co-authored-by: Readeem <Readeem@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: JustaSqu1d <89910983+JustaSqu1d@users.noreply.github.com> Co-authored-by: Lala Sabathil <lala@pycord.dev> Co-authored-by: plun1331 <plun1331@gmail.com> * docs: fix ext.bridge menu behavior (Pycord-Development#2566) change data to autoclass * feat: add missing AppInfo attributes (Pycord-Development#2520) * feat: add missing AppInfo attributes * fix: add `install_params` to slots * docs: add related documentation * style(pre-commit): auto fixes from pre-commit.com hooks * fix: typing * docs: fix spacing * style(pre-commit): auto fixes from pre-commit.com hooks * fix: add AppInstallParams to `__all__` * fix: invalid scopes typehint * fix: docs types formatting * docs: add changelog entry * style(pre-commit): auto fixes from pre-commit.com hooks * feat: deprecate `AppInfo.summary` * style(pre-commit): auto fixes from pre-commit.com hooks * docs: fix changelog to adhere to conventions * fix: properly deprecate `summary` * docs: fix `tags` typing * style(pre-commit): auto fixes from pre-commit.com hooks * docs: fix summary formatting --------- Signed-off-by: JustaSqu1d <89910983+JustaSqu1d@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Lala Sabathil <lala@pycord.dev> * chore(deps-dev): update pylint requirement from ~=3.2.6 to ~=3.2.7 in the major-version-bumps group (Pycord-Development#2567) chore(deps-dev): update pylint requirement Updates the requirements on [pylint](https://github.com/pylint-dev/pylint) to permit the latest version. Updates `pylint` to 3.2.7 - [Release notes](https://github.com/pylint-dev/pylint/releases) - [Commits](pylint-dev/pylint@v3.2.6...v3.2.7) --- updated-dependencies: - dependency-name: pylint dependency-type: direct:development dependency-group: major-version-bumps ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: allow PartialMessage to have PartialMessageable as a channel (Pycord-Development#2568) * fix: allow PartialMessage to have PartialMessageable as a channel Signed-off-by: plun1331 <plun1331@gmail.com> * Update CHANGELOG.md Signed-off-by: plun1331 <plun1331@gmail.com> * style(pre-commit): auto fixes from pre-commit.com hooks --------- Signed-off-by: plun1331 <plun1331@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * docs: Update localizations from Crowdin (Pycord-Development#2570) Co-authored-by: Crowdin Bot <support+bot@crowdin.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: JustaSqu1d <89910983+JustaSqu1d@users.noreply.github.com> Signed-off-by: UK <41271523+NeloBlivion@users.noreply.github.com> Signed-off-by: plun1331 <plun1331@gmail.com> Signed-off-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com> Signed-off-by: Lala Sabathil <lala@pycord.dev> Signed-off-by: Lala Sabathil <aiko@aitsys.dev> Signed-off-by: Matty Widdop <18513864+MattyTheHacker@users.noreply.github.com> Signed-off-by: Readeem <99687127+Readeem@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: JustaSqu1d <89910983+JustaSqu1d@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com> Co-authored-by: Lala Sabathil <lala@pycord.dev> Co-authored-by: UK <41271523+NeloBlivion@users.noreply.github.com> Co-authored-by: Icebluewolf <44532864+Icebluewolf@users.noreply.github.com> Co-authored-by: Timo <35654063+tibue99@users.noreply.github.com> Co-authored-by: Lala Sabathil <aiko@aitsys.dev> Co-authored-by: Paillat <jeremiecotti@ik.me> Co-authored-by: Bruno Alvalat <bruno.alatriste@gmail.com> Co-authored-by: Paillat <me@paillat.dev> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Crowdin Bot <support+bot@crowdin.com> Co-authored-by: Nyuw~ <nyuw@aitsys.dev> Co-authored-by: YoggieS <61660055+yoggys@users.noreply.github.com> Co-authored-by: Matty Widdop <18513864+MattyTheHacker@users.noreply.github.com> Co-authored-by: Readeem <99687127+Readeem@users.noreply.github.com> Co-authored-by: Readeem <Readeem@users.noreply.github.com>

* Fix premium buttons * Fix EntitlementIterator call * Test yarl bool * Add TODO * style(pre-commit): auto fixes from pre-commit.com hooks * Cast `exclude_ended` to int * Fix cast * Adjust fetch_entitlements to match other iterators * Add changelog --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

tibue99 added 4 commits July 1, 2024 16:44

Fix premium buttons

8d035e1

Fix EntitlementIterator call

e963b7c

Test yarl bool

27bdb2d

Add TODO

e2ca50b

tibue99 requested a review from a team as a code owner July 1, 2024 16:10

pullapprove4 bot requested a review from ChickenDevs July 1, 2024 16:10

pullapprove4 bot added PA: All Contributors pending PA: Maintainers pending labels Jul 1, 2024

style(pre-commit): auto fixes from pre-commit.com hooks

8249e67

Cast exclude_ended to int

65ebab3

plun1331 reviewed Jul 1, 2024

View reviewed changes

discord/iterators.py Outdated Show resolved Hide resolved

plun1331 added bug Something isn't working priority: high High Priority status: in progress Work in Progess labels Jul 1, 2024

plun1331 added this to the v2.6 milestone Jul 1, 2024

Fix cast

6e1714a

NeloBlivion suggested changes Jul 1, 2024

View reviewed changes

pullapprove4 bot removed the PA: All Contributors pending label Jul 1, 2024

Adjust fetch_entitlements to match other iterators

a53cbab

tibue99 requested a review from NeloBlivion July 1, 2024 21:31

pullapprove4 bot added the PA: All Contributors pending label Jul 1, 2024

NeloBlivion approved these changes Jul 1, 2024

View reviewed changes

Dorukyum previously requested changes Jul 2, 2024

View reviewed changes

pullapprove4 bot removed PA: All Contributors pending PA: Maintainers pending labels Jul 2, 2024

Dorukyum reviewed Jul 2, 2024

View reviewed changes

discord/client.py Outdated Show resolved Hide resolved

tibue99 added 2 commits July 2, 2024 15:18

Merge branch 'master' into monetization-fixes

a9ee043

Add changelog

4119281

tibue99 requested a review from Dorukyum July 2, 2024 13:39

pullapprove4 bot added PA: All Contributors pending PA: Maintainers pending labels Jul 2, 2024

Dorukyum requested review from plun1331 and removed request for ChickenDevs July 3, 2024 06:42

Lulalaby previously approved these changes Jul 3, 2024

View reviewed changes

pullapprove4 bot removed PA: All Contributors pending PA: Maintainers pending labels Jul 3, 2024

Lulalaby requested a review from NeloBlivion July 3, 2024 11:38

pullapprove4 bot added the PA: All Contributors pending label Jul 3, 2024

Lulalaby enabled auto-merge (squash) July 3, 2024 11:39

plun1331 reviewed Jul 3, 2024

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

Update CHANGELOG.md

37958fb

Signed-off-by: plun1331 <plun1331@gmail.com>

plun1331 dismissed Lulalaby’s stale review via 37958fb July 3, 2024 20:40

pullapprove4 bot added the PA: Maintainers pending label Jul 3, 2024

plun1331 approved these changes Jul 3, 2024

View reviewed changes

pullapprove4 bot removed the PA: Maintainers pending label Jul 3, 2024

NeloBlivion approved these changes Jul 3, 2024

View reviewed changes

pullapprove4 bot removed the PA: All Contributors pending label Jul 3, 2024

Lulalaby merged commit ec3cf16 into Pycord-Development:master Jul 3, 2024
29 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: premium buttons and entitlement iterator #2490

fix: premium buttons and entitlement iterator #2490

tibue99 commented Jul 1, 2024 •

edited

Loading

plun1331 commented Jul 1, 2024 •

edited

Loading

NeloBlivion left a comment •

edited

Loading

Lulalaby commented Jul 1, 2024

Dorukyum left a comment •

edited

Loading

Dorukyum commented Jul 2, 2024

tibue99 commented Jul 2, 2024

Lulalaby left a comment

fix: premium buttons and entitlement iterator #2490

fix: premium buttons and entitlement iterator #2490

Conversation

tibue99 commented Jul 1, 2024 • edited Loading

Summary

Information

Checklist

plun1331 commented Jul 1, 2024 • edited Loading

NeloBlivion left a comment • edited Loading

Choose a reason for hiding this comment

Lulalaby commented Jul 1, 2024

Dorukyum left a comment • edited Loading

Choose a reason for hiding this comment

Dorukyum commented Jul 2, 2024

tibue99 commented Jul 2, 2024

Lulalaby left a comment

Choose a reason for hiding this comment

tibue99 commented Jul 1, 2024 •

edited

Loading

plun1331 commented Jul 1, 2024 •

edited

Loading

NeloBlivion left a comment •

edited

Loading

Dorukyum left a comment •

edited

Loading