fix: 🐛 `TypeError` when specifying `thread_name` in Webhook.send #2761

Paillat-dev · 2025-04-04T21:18:56Z

Summary

Information

This PR fixes an issue.
This PR adds something new (e.g. new method or parameters).
This PR is a breaking change (e.g. methods or parameters removed/renamed).
This PR is not a code change (e.g. documentation, README, typehinting,
examples, ...).

Checklist

I have searched the open pull requests for duplicates.
If code changes were made then they have been tested.
- I have updated the documentation to reflect the changes.
If type: ignore comments were used, a comment is also left explaining why.
I have updated the changelog to include these changes.

Lumabots · 2025-04-05T07:47:37Z

kwargs = {'content': '<@1118670495466934274>', 'username': 'Winiii', 'avatar_url': 'https://cdn.discordapp.com/attachments/1357984230285643797/1357984578232389754/1302995806780919898.png?ex=67f23131&is=67f0dfb1&hm=925cec84d69c8d3505074c30b5504e020206341016cd7fd397a83ced339913e1&', 'embeds': [], 'files': [<discord.file.File object at 0x7f1f6c34bbe0>, <discord.file.File object at 0x7f1f6c34a140>], 'allowed_mentions': AllowedMentions(everyone=False, users=False, roles=False, replied_user=False), 'wait': True, 'thread_name': "Hey je programme un pote pour du rp Harry Potter et j'aurai besoin d'aide en BDD"}

message = await backup_webhook.send(**kwargs)

    |   File "/home/container/.local/lib/python3.11/site-packages/discord/webhook/async_.py", line 1818, in send
    |     data = await adapter.execute_webhook(
    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |   File "/home/container/.local/lib/python3.11/site-packages/discord/webhook/async_.py", line 225, in request
    |     raise HTTPException(response, data)
    | discord.errors.HTTPException: 400 Bad Request (error code: 50109): The request body contains invalid JSON.

In case that can help

Paillat-dev · 2025-04-06T13:03:18Z

@Lumabots sorry for the delay, I'll be gone till Friday so won't be able to work on this. I'll take a look when I'm back.

Paillat-dev · 2025-04-17T20:44:10Z

@Lumabots I was looking at this again but I'm kinda lost... Would you mind sending a reference to the message where the issue was discussed on discord or some code to reproduce ?

Lumabots · 2025-04-18T13:53:41Z

@Lumabots I was looking at this again but I'm kinda lost... Would you mind sending a reference to the message where the issue was discussed on discord or some code to reproduce ?

https://discord.com/channels/881207955029110855/1132206148309749830/1357721402764955688

Lumabots · 2025-04-26T14:28:05Z

do you need help on this one @Paillat-dev ?

Paillat-dev · 2025-04-26T14:31:15Z

No just waiting for some moment when I have time I'm quite busy atm

…g to thread with multipart

Signed-off-by: Paillat <me@paillat.dev>

CHANGELOG.md

Co-authored-by: plun1331 <plun1331@gmail.com> Signed-off-by: Paillat <jeremiecotti@ik.me>

Signed-off-by: Paillat <me@paillat.dev>

* fix: Role Edit TypeHint (Pycord-Development#2795) Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com> * fix: command syncing edge cases (Pycord-Development#2797) * change default nsfw to false * cl * localizations * := * style(pre-commit): auto fixes from pre-commit.com hooks --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * fix: VoiceClient crashes while receiving audio (Pycord-Development#2800) Signed-off-by: Hema2 <49586027+Hema2-official@users.noreply.github.com> Co-authored-by: Lala Sabathil <lala@pycord.dev> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * chore(deps): bump typing-extensions from 4.13.1 to 4.13.2 in the patch-version-bumps group (Pycord-Development#2783) chore(deps): bump typing-extensions in the patch-version-bumps group Bumps the patch-version-bumps group with 1 update: [typing-extensions](https://github.com/python/typing_extensions). Updates `typing-extensions` from 4.13.1 to 4.13.2 - [Release notes](https://github.com/python/typing_extensions/releases) - [Changelog](https://github.com/python/typing_extensions/blob/main/CHANGELOG.md) - [Commits](python/typing_extensions@4.13.1...4.13.2) --- updated-dependencies: - dependency-name: typing-extensions dependency-version: 4.13.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: patch-version-bumps ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat: add created_at property to Interaction (Pycord-Development#2801) * feat: add created_at property to Interaction for message creation time * Update CHANGELOG.md * Update discord/interactions.py Co-authored-by: UK <41271523+NeloBlivion@users.noreply.github.com> Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com> * Update CHANGELOG.md Co-authored-by: DA344 <108473820+DA-344@users.noreply.github.com> Signed-off-by: Lala Sabathil <aiko@aitsys.dev> --------- Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com> Signed-off-by: Lala Sabathil <aiko@aitsys.dev> Co-authored-by: UK <41271523+NeloBlivion@users.noreply.github.com> Co-authored-by: Lala Sabathil <aiko@aitsys.dev> Co-authored-by: DA344 <108473820+DA-344@users.noreply.github.com> * chore(deps): update setuptools requirement from <=78.1.0,>=62.6 to >=62.6,<=80.8.0 (Pycord-Development#2786) chore(deps): update setuptools requirement Updates the requirements on [setuptools](https://github.com/pypa/setuptools) to permit the latest version. - [Release notes](https://github.com/pypa/setuptools/releases) - [Changelog](https://github.com/pypa/setuptools/blob/main/NEWS.rst) - [Commits](pypa/setuptools@v72.2.0...v80.8.0) --- updated-dependencies: - dependency-name: setuptools dependency-version: 80.8.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore!: 🔥 Remove deprecated support for Option in bridge commands (Pycord-Development#2731) * 🔥 Remove deprecated support for Option in bridge commands * 📝 CHANGELOG.md * ♻️ Better logic --------- Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com> * fix: 🐛 `TypeError` when specifying `thread_name` in Webhook.send (Pycord-Development#2761) * 🐛 Handle `thread_name` in `handle_message_parameters` to allow sending to thread with multipart * 📝 CHANGELOG.md * Update CHANGELOG.md Co-authored-by: plun1331 <plun1331@gmail.com> Signed-off-by: Paillat <jeremiecotti@ik.me> --------- Signed-off-by: Paillat <me@paillat.dev> Signed-off-by: Paillat <jeremiecotti@ik.me> Co-authored-by: plun1331 <plun1331@gmail.com> Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com> * fix: add BanEntry to __all__ exports in guild.py (Pycord-Development#2798) * fix: add BanEntry to __all__ exports in guild.py * Hold on Signed-off-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com> --------- Signed-off-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com> Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com> * fix: correct generic return type in component utils (Pycord-Development#2796) * Update CHANGELOG.md Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com> * sync with pycord * fix: update Item type hints to Item[View] in view.py * fix: update Item type hints to use TypeVar[V] in view.py --------- Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com> Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com> * chore(deps): update setuptools-scm requirement from <=8.2.1,>=6.2 to >=6.2,<=8.3.1 (Pycord-Development#2785) chore(deps): update setuptools-scm requirement Updates the requirements on [setuptools-scm](https://github.com/pypa/setuptools-scm) to permit the latest version. - [Release notes](https://github.com/pypa/setuptools-scm/releases) - [Changelog](https://github.com/pypa/setuptools-scm/blob/main/CHANGELOG.md) - [Commits](pypa/setuptools-scm@v8.1.0...v8.3.1) --- updated-dependencies: - dependency-name: setuptools-scm dependency-version: 8.3.1 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): update pylint requirement from ~=3.3.6 to ~=3.3.7 (Pycord-Development#2784) Updates the requirements on [pylint](https://github.com/pylint-dev/pylint) to permit the latest version. - [Release notes](https://github.com/pylint-dev/pylint/releases) - [Commits](pylint-dev/pylint@v3.3.6...v3.3.7) --- updated-dependencies: - dependency-name: pylint dependency-version: 3.3.7 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(pre-commit): pre-commit autoupdate (Pycord-Development#2792) updates: - [github.com/asottile/pyupgrade: v3.19.1 → v3.20.0](asottile/pyupgrade@v3.19.1...v3.20.0) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * docs: 📝 Fix malformed CHANGELOG.md hyperlinks (Pycord-Development#2804) :memo: Fix CHANGELOG.md formatting * fix: :bug: Fix `ValueError` when using `Flag` (Pycord-Development#2759) * 🐛 Fix `dataclasses.field` can't be reused * 📝 CHANGELOG.md * Update CHANGELOG.md Signed-off-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com> * ♻️ Move `_missing_field_factory` to flags.py and remove incorrect comment --------- Signed-off-by: Paillat <me@paillat.dev> Signed-off-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com> Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com> * ci(deps): bump crowdin/github-action from 2.7.0 to 2.7.1 in the patch-version-bumps group (Pycord-Development#2805) ci(deps): bump crowdin/github-action in the patch-version-bumps group Bumps the patch-version-bumps group with 1 update: [crowdin/github-action](https://github.com/crowdin/github-action). Updates `crowdin/github-action` from 2.7.0 to 2.7.1 - [Release notes](https://github.com/crowdin/github-action/releases) - [Commits](crowdin/github-action@v2.7.0...v2.7.1) --- updated-dependencies: - dependency-name: crowdin/github-action dependency-version: 2.7.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: patch-version-bumps ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: resolve regex library warnings (Pycord-Development#2807) Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com> * fix: support emoji aliases like `:smile:` in PartialEmoji.from_str (Pycord-Development#2774) * handle emoji_lib Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com> * style(pre-commit): auto fixes from pre-commit.com hooks * Update CHANGELOG.md Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com> * usage of dismoji Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com> * Update _.txt Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com> * removal of dismoji Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com> * Update _.txt Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com> * style(pre-commit): auto fixes from pre-commit.com hooks * NEED HELP Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com> * style(pre-commit): auto fixes from pre-commit.com hooks * Update partial_emoji.py Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com> * style(pre-commit): auto fixes from pre-commit.com hooks * Add files via upload Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com> * style(pre-commit): auto fixes from pre-commit.com hooks * Update partial_emoji.py Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com> * Update discord/partial_emoji.py Co-authored-by: plun1331 <plun1331@gmail.com> Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com> * feature(partial_emoji): support :name: and name * fix(partial_emoji): remove unnecessary data variable after processing emojis * Update partial_emoji.py Co-authored-by: Paillat <jeremiecotti@ik.me> Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com> * reduce emoji.json weight * Update emojis.json Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com> * refactor: replace Path with importlib.resources for loading emojis.json * Update emojis.json Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com> --------- Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: plun1331 <plun1331@gmail.com> Co-authored-by: Paillat <jeremiecotti@ik.me> Co-authored-by: Lala Sabathil <lala@pycord.dev> * Revert "fix: support emoji aliases like `😄` in PartialEmoji.from_str" (Pycord-Development#2814) Revert "fix: support emoji aliases like `:smile:` in PartialEmoji.from_str (#…" This reverts commit 735673b. * Apply suggestions from code review Signed-off-by: Paillat <jeremiecotti@ik.me> * Update discord/utils.py Signed-off-by: Paillat <jeremiecotti@ik.me> * Update discord/utils.py Signed-off-by: Paillat <jeremiecotti@ik.me> * Update discord/ext/commands/flags.py Signed-off-by: Paillat <jeremiecotti@ik.me> * 🚨 Fix linter warnings --------- Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com> Signed-off-by: Hema2 <49586027+Hema2-official@users.noreply.github.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Lala Sabathil <aiko@aitsys.dev> Signed-off-by: Paillat <me@paillat.dev> Signed-off-by: Paillat <jeremiecotti@ik.me> Signed-off-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com> Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com> Co-authored-by: Lumouille <144063653+Lumabots@users.noreply.github.com> Co-authored-by: UK <41271523+NeloBlivion@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Hema2 <49586027+Hema2-official@users.noreply.github.com> Co-authored-by: Lala Sabathil <lala@pycord.dev> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Lala Sabathil <aiko@aitsys.dev> Co-authored-by: DA344 <108473820+DA-344@users.noreply.github.com> Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com> Co-authored-by: plun1331 <plun1331@gmail.com> Co-authored-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>

Paillat-dev force-pushed the fix/webhook-thread-name branch from a81805f to 6b29bdd Compare May 5, 2025 09:12

Paillat-dev added 2 commits May 5, 2025 11:13

🐛 Handle thread_name in handle_message_parameters to allow sendin…

858d695

…g to thread with multipart

📝 CHANGELOG.md

3f5aced

Paillat-dev force-pushed the fix/webhook-thread-name branch from 6b29bdd to 3f5aced Compare May 5, 2025 09:13

Merge branch 'master' into fix/webhook-thread-name

f63280f

Signed-off-by: Paillat <me@paillat.dev>

Paillat-dev marked this pull request as ready for review May 5, 2025 09:17

Paillat-dev requested a review from a team as a code owner May 5, 2025 09:17

pullapprove4 bot requested a review from Dorukyum May 5, 2025 09:17

pullapprove4 bot added PA: All Contributors pending PA: Maintainers pending labels May 5, 2025

plun1331 reviewed May 9, 2025

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

Paillat-dev and others added 2 commits May 9, 2025 21:36

Update CHANGELOG.md

a95cfbe

Co-authored-by: plun1331 <plun1331@gmail.com> Signed-off-by: Paillat <jeremiecotti@ik.me>

Merge branch 'master' into fix/webhook-thread-name

90855a4

Paillat-dev requested a review from plun1331 May 9, 2025 19:36

Merge branch 'master' into fix/webhook-thread-name

8e796de

Signed-off-by: Paillat <me@paillat.dev>

Dorukyum added hold: testing This pull request requires further testing and removed hold: testing This pull request requires further testing labels Jun 4, 2025

Dorukyum approved these changes Jun 4, 2025

View reviewed changes

pullapprove4 bot removed the PA: Maintainers pending label Jun 4, 2025

Merge branch 'master' into fix/webhook-thread-name

561d7d8

Dorukyum enabled auto-merge (squash) June 4, 2025 10:43

Lulalaby disabled auto-merge June 4, 2025 19:18

Lulalaby approved these changes Jun 4, 2025

View reviewed changes

pullapprove4 bot removed the PA: All Contributors pending label Jun 4, 2025

Lulalaby merged commit 7efe9a2 into Pycord-Development:master Jun 4, 2025
28 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix: 🐛 `TypeError` when specifying `thread_name` in Webhook.send #2761

fix: 🐛 `TypeError` when specifying `thread_name` in Webhook.send #2761

Uh oh!

Paillat-dev commented Apr 4, 2025 •

edited by Dorukyum

Loading

Uh oh!

Lumabots commented Apr 5, 2025

Uh oh!

Paillat-dev commented Apr 6, 2025

Uh oh!

Paillat-dev commented Apr 17, 2025

Uh oh!

Lumabots commented Apr 18, 2025

Uh oh!

Lumabots commented Apr 26, 2025

Uh oh!

Paillat-dev commented Apr 26, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

fix: 🐛 TypeError when specifying thread_name in Webhook.send #2761

fix: 🐛 TypeError when specifying thread_name in Webhook.send #2761

Uh oh!

Conversation

Paillat-dev commented Apr 4, 2025 • edited by Dorukyum Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Information

Checklist

Uh oh!

Lumabots commented Apr 5, 2025

Uh oh!

Paillat-dev commented Apr 6, 2025

Uh oh!

Paillat-dev commented Apr 17, 2025

Uh oh!

Lumabots commented Apr 18, 2025

Uh oh!

Lumabots commented Apr 26, 2025

Uh oh!

Paillat-dev commented Apr 26, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

fix: 🐛 `TypeError` when specifying `thread_name` in Webhook.send #2761

fix: 🐛 `TypeError` when specifying `thread_name` in Webhook.send #2761

Paillat-dev commented Apr 4, 2025 •

edited by Dorukyum

Loading