-
-
Notifications
You must be signed in to change notification settings - Fork 484
Add support for Input Text and Modal components #573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
import crisis lmao |
Member
|
HAHAHAHA |
Member
|
We def have to squash it :p |
Contributor
Author
|
This is ready for review, though probably shouldn't be merged until modals are publicly released. |
Member
|
Thanks for fixing the other things too! |
VincentRPS
approved these changes
Dec 22, 2021
Contributor
VincentRPS
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works fine in my testing
Lulalaby
approved these changes
Dec 22, 2021
Contributor
Author
|
Remaking PR as my fork broke. |
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
discord limitation
Limitation imposed by discord
feature
Implements a feature
priority: medium
Medium Priority
status: planned
Planned in the future
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Note: Pretty much done, works as expected. Might need some more work on docstrings.
Checklist:
This adds support for input text and modal components.
Closes #490
Checklist
type: ignorecomments were used, a comment is also left explaining whyCredit to @Chiggy-Playz for their guidance in pointing me toward re-using many of the methodologies from View/Button/Select to quickly get our implementation running.