Skip to content

Conversation

@krittick
Copy link
Contributor

@krittick krittick commented Dec 15, 2021

Summary

Note: Pretty much done, works as expected. Might need some more work on docstrings.

Checklist:

  • Base objects/classes/enums
    • Input Text
    • Modals
  • Docstrings
    • Input Text
    • Modals
  • Examples to show usage

This adds support for input text and modal components.

Closes #490

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

Credit to @Chiggy-Playz for their guidance in pointing me toward re-using many of the methodologies from View/Button/Select to quickly get our implementation running.

@Middledot Middledot added feature Implements a feature priority: low Low Priority status: in progress Work in Progess labels Dec 16, 2021
@Middledot Middledot assigned Middledot and krittick and unassigned Middledot Dec 16, 2021
@Lulalaby Lulalaby self-assigned this Dec 16, 2021
@Lulalaby Lulalaby added this to the v2.1 milestone Dec 16, 2021
@Lulalaby Lulalaby added discord limitation Limitation imposed by discord priority: medium Medium Priority and removed priority: low Low Priority labels Dec 16, 2021
@VincentRPS
Copy link
Contributor

import crisis lmao

@Lulalaby
Copy link
Member

HAHAHAHA

@Lulalaby
Copy link
Member

We def have to squash it :p

@krittick krittick marked this pull request as ready for review December 19, 2021 00:13
@krittick
Copy link
Contributor Author

This is ready for review, though probably shouldn't be merged until modals are publicly released.

@Lulalaby Lulalaby enabled auto-merge (squash) December 19, 2021 00:22
@Lulalaby
Copy link
Member

Thanks for fixing the other things too!

@Lulalaby Lulalaby added status: planned Planned in the future and removed status: in progress Work in Progess labels Dec 19, 2021
@Lulalaby Lulalaby disabled auto-merge December 19, 2021 00:34
@Lulalaby Lulalaby modified the milestones: v2.1, v2.0 Dec 19, 2021
@Lulalaby Lulalaby enabled auto-merge December 19, 2021 21:34
@Lulalaby Lulalaby disabled auto-merge December 19, 2021 21:34
Copy link
Contributor

@VincentRPS VincentRPS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works fine in my testing

@Lulalaby Lulalaby enabled auto-merge December 22, 2021 11:48
@Lulalaby Lulalaby disabled auto-merge December 22, 2021 11:48
@krittick
Copy link
Contributor Author

Remaking PR as my fork broke.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

discord limitation Limitation imposed by discord feature Implements a feature priority: medium Medium Priority status: planned Planned in the future

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Support for Modals & Input Text in Application Commands

4 participants