Skip to content

Slash Attachments #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Lulalaby merged 10 commits into from
Feb 9, 2022
Merged

Slash Attachments #579

Lulalaby merged 10 commits into from
Feb 9, 2022

Conversation

@Lulalaby
Copy link
Member

@Lulalaby Lulalaby commented Dec 17, 2021

No description provided.

@Lulalaby Lulalaby added discord limitation Limitation imposed by discord priority: medium Medium Priority status: todo This issue needs work feature Implements a feature labels Dec 17, 2021
@Lulalaby Lulalaby added this to the v2.0 milestone Dec 17, 2021
@Lulalaby Lulalaby self-assigned this Dec 17, 2021
izxxr
izxxr reviewed Dec 18, 2021
View reviewed changes
@Lulalaby @izxxr
Update discord/types/interactions.py
04c88c3 
Co-authored-by: Izhar Ahmad <54180221+nerdguyahmad@users.noreply.github.com>
@Lulalaby
Copy link
Member Author

Lulalaby commented Dec 18, 2021

@nerdguyahmad could you implement the rest?

@izxxr
Copy link
Contributor

izxxr commented Dec 18, 2021

@nerdguyahmad could you implement the rest?

Sure.

@Lulalaby
Copy link
Member Author

Lulalaby commented Dec 18, 2021

I'm too unfamiliar with it sadly.
correct implementation is here:
https://github.com/Aiko-IT-Systems/Discord-API-Docs/commit/4c28ec59a666a668456d3412e9ecde97e0f4220f
I can't pr it to dapi docs because of drama. There is a pr, but it's incorrect.

Attachments are missing the ephemeral flag

@Dorukyum
Copy link
Member

Dorukyum commented Jan 1, 2022

Could a checklist for what's left on this be added?

@Lulalaby Lulalaby modified the milestones: v2.0, v2.1 Jan 1, 2022
@krittick krittick mentioned this pull request Jan 13, 2022
Closed
@Dorukyum Dorukyum assigned Dorukyum and unassigned izxxr Jan 29, 2022
@Dorukyum Dorukyum marked this pull request as ready for review January 29, 2022 17:53
@Lulalaby Lulalaby enabled auto-merge (squash) January 29, 2022 18:45
@Dorukyum
Copy link
Member

Dorukyum commented Jan 30, 2022 •
edited
Loading

Update: added parsing for received attachments, tested with a txt file
Ready for review.

Not to be merged until release.

@Dorukyum Dorukyum added status: awaiting review Awaiting review from a maintainer and removed status: todo This issue needs work labels Jan 30, 2022
@Lulalaby
Copy link
Member Author

Lulalaby commented Jan 30, 2022

Thanks ❤️

@Middledot Middledot added priority: high High Priority and removed discord limitation Limitation imposed by discord priority: medium Medium Priority labels Feb 9, 2022
@krittick krittick mentioned this pull request Feb 9, 2022
Merged
7 tasks
@Lulalaby Lulalaby merged commit 5806985 into master Feb 9, 2022
@Middledot Middledot deleted the features/application-option-11 branch February 9, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Middledot Middledot Middledot approved these changes

@Dorukyum Dorukyum Awaiting requested review from Dorukyum

+2 more reviewers

@izxxr izxxr izxxr left review comments

@krittick krittick krittick approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Lulalaby Lulalaby

@Dorukyum Dorukyum

Labels

feature Implements a feature priority: high High Priority status: awaiting review Awaiting review from a maintainer

Projects

Pycord Releases
Status: No status

Milestone

v2.1

Development

Successfully merging this pull request may close these issues.

5 participants

@Lulalaby @izxxr @Dorukyum @krittick @Middledot