Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Form.formid has no effect on Field.oid autogeneration #394

Open
ezag opened this issue Feb 6, 2020 · 1 comment
Open

Form.formid has no effect on Field.oid autogeneration #394

ezag opened this issue Feb 6, 2020 · 1 comment
Labels
bug needs-pr should backport
Milestone
3.0.0

Comments

@ezag
Copy link

ezag commented Feb 6, 2020 •
edited
Loading

As per docs, formid argument is intended for placing more than one Deform form into a single page. Though autogenerated oids will conflict in this case (violating HTML standard and breaking JS that rely on DOM ids) unless being explicitly specified in schema, or multiple forms being initialized with a shared counter. Could this be fixed by making parent formid a part of autogenerated oid?
@stevepiercy
Copy link
Member

@ezag I think that is a good proposal. Would you like to submit a PR with tests? I'd accept it.

Please note that we are dropping Python 2.7 and 3.4 in the next release, so you don't need to test for that.

@stevepiercy stevepiercy added this to the 3.0.0 milestone Aug 26, 2020
ezag added a commit to ezag/deform that referenced this issue Jun 11, 2021
@ezag
Make parent formid a part of autorenerated oid
6863f9d 
Pylons#394
@ezag ezag mentioned this issue Jun 11, 2021
Open
ezag added a commit to ezag/deform that referenced this issue Jun 11, 2021
@ezag
Make parent formid a part of autogenerated oid
f364816 
Pylons#394
ezag added a commit to ezag/deform that referenced this issue Oct 22, 2021
@ezag
Make parent formid a part of autogenerated oid
3cc3908 
Pylons#394
ezag added a commit to ezag/deformdemo that referenced this issue Oct 22, 2021
@ezag
A counter is no longer required for multiple forms
5100c02 
Pylons/deform#394
ezag added a commit to ezag/deform that referenced this issue Oct 22, 2021
@ezag
Make parent formid a part of autogenerated oid
f0e16dd 
Pylons#394
@ezag ezag mentioned this issue Oct 22, 2021
Open
ezag added a commit to ezag/deform that referenced this issue Oct 22, 2021
@ezag
Make parent formid a part of autogenerated oid
065df8c 
Pylons#394
ezag added a commit to ezag/deform that referenced this issue Oct 23, 2021
@ezag
Make parent formid a part of autogenerated oid
6fb486c 
Pylons#394
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug needs-pr should backport
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
2 participants
@stevepiercy @ezag