-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update custom widget example in docs #226
Conversation
My only issue with this change is that it's combining string concatenation with |
Fully agree, I updated the branch. |
one more nitpick... :) http://legacy.python.org/dev/peps/pep-0008/#maximum-line-length instead of:
you could do one of these:
Basically you want to avoid the backslash because it breaks if there's any white space directly after it and white space is hard to notice at the end of a line. |
The example for a custom widget in the docs builds an input field like this: return u'<input type="text" value="%s">' % quoted But the `name` property is not set, so no data would be submitted for this field.
Updated :) |
@stevepiercy this should be merged. |
@tsauerwein thank you! Sorry for the long delay. I've recently taken on the role of maintainer for Deform. |
(cherry picked from commit b7442ed)
Update widget docs per #226 for consistency across code examples
The example for a custom widget in the docs builds an input field like this:
But the
name
property is not set, so no data would be submitted for this field.