Prettify the FileUploadWidget #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Very clever ideas blantantly ripped-off from http://www.abeautifulsite.net/blog/2013/08/whipping-file-inputs-into-shape-with-bootstrap-3/ Issues: I've not tested this with many browsers. I'm not sure where to put the id="${oid}". (Is it really even necessary?) Putting on the file input element causes deform.js to focus it (if it's the first field on the page) which, I guess because it is not visible, results in unwanted scrolling.
Move what's left of the custom CSS into form.css.
The .input-group has display: table. This appears to cause Firefox to ignore the overflow: hidden. This results in the file select dialog being triggered by clicks anywhere in a large region above and/or to the left of the file widget.
This was referenced Sep 16, 2015
|
Thank you for your pull request. I am the new Deform project maintainer. I apologize the issue of this pull request not being commented earlier. Deform project is again under activate maintenance. This is issue tracker / pull request clean to prepare a new release. This pull request is good to go and merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the FileUploadWidget look nicer, providing a "Select file" button styled by bootstrap.
This is PR #184 rebased onto the current master. See that PR for some more context.