-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTML5 datetime input #406
HTML5 datetime input #406
Conversation
This PR needs to pass all tests and linting before it can be merged. But before you work on that, note that we are moving to Bootstrap 4 in Deform 3.0. If people want to maintain Deform 2.0.x with Bootstrap 3, I can create a branch that can be actively maintained by whoever wanders by. All new development and maintenance is focused on Bootstrap 4 and Deform 3.0. Also note that we will likely use a different datetime picker. One option is Flatpickr as mentioned in #405. |
I've merged the two PRs referenced above into master. You will could either:
|
42a9d43
to
5f807ef
Compare
I decided to do the former, since I don't have a requirement to use Bootstrap 3. Tests pass on my local machine, now waiting to see if Travis finds any problems. |
@jhaiduce this looks good with only one minor change. If you have not already done so, would you please sign https://github.com/Pylons/deform/blob/master/CONTRIBUTORS.txt and push to this PR? After that I will merge. Thank you! |
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Done. Thank you! |
Thank you! |
This PR modifies the DateTimeInputWidget to use HTML5 date/time input types on browsers that support it.