Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML5 datetime input #406

Merged
merged 6 commits into from
Jun 20, 2020
Merged

Conversation

jhaiduce
Copy link
Contributor

This PR modifies the DateTimeInputWidget to use HTML5 date/time input types on browsers that support it.

@stevepiercy
Copy link
Member

This PR needs to pass all tests and linting before it can be merged. But before you work on that, note that we are moving to Bootstrap 4 in Deform 3.0. If people want to maintain Deform 2.0.x with Bootstrap 3, I can create a branch that can be actively maintained by whoever wanders by. All new development and maintenance is focused on Bootstrap 4 and Deform 3.0.

Also note that we will likely use a different datetime picker. One option is Flatpickr as mentioned in #405.

@stevepiercy
Copy link
Member

I've merged the two PRs referenced above into master. You will could either:

  • rebase this PR on master, then push to this PR
  • create a new branch off of master and create a new PR, closing this one

@jhaiduce jhaiduce force-pushed the html5_datetime_input branch from 42a9d43 to 5f807ef Compare June 19, 2020 22:34
@jhaiduce
Copy link
Contributor Author

I've merged the two PRs referenced above into master. You will could either:

* rebase this PR on master, then push to this PR

* create a new branch off of master and create a new PR, closing this one

I decided to do the former, since I don't have a requirement to use Bootstrap 3.

Tests pass on my local machine, now waiting to see if Travis finds any problems.

deform/templates/datetimeinput.pt Outdated Show resolved Hide resolved
@stevepiercy
Copy link
Member

@jhaiduce this looks good with only one minor change.

If you have not already done so, would you please sign https://github.com/Pylons/deform/blob/master/CONTRIBUTORS.txt and push to this PR?

After that I will merge. Thank you!

@stevepiercy stevepiercy added this to the 3.0.0 milestone Jun 20, 2020
jhaiduce and others added 2 commits June 20, 2020 16:00
@jhaiduce
Copy link
Contributor Author

@jhaiduce this looks good with only one minor change.

If you have not already done so, would you please sign https://github.com/Pylons/deform/blob/master/CONTRIBUTORS.txt and push to this PR?

Done. Thank you!

@stevepiercy stevepiercy merged commit eedaa31 into Pylons:master Jun 20, 2020
@stevepiercy
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants