Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs code style #3330

Merged
merged 81 commits into from
Aug 21, 2018
Merged

Docs code style #3330

merged 81 commits into from
Aug 21, 2018

Conversation

@stevepiercy stevepiercy added this to the 1.10 milestone Aug 19, 2018
@mmerickel
Copy link
Member

@stevepiercy have you investigated any options for enforcing linting/style guides on the rst?

@stevepiercy
Copy link
Member Author

I had not considered adding some automated checking, but that's a good idea. I'd create a separate PR for this new feature.

I follow what Plone and WriteTheDocs do.

Some stuff can be automated without too much difficulty, and would be helpful and unobtrusive:

There's also dozens of other projects that look for passive voice, "weasel words", and other linguistic violations, but I feel that's overkill and beyond our resources as an open source project to enforce. I think it would turn off contributors to have a Language Police robot.

If I were to implement any new CI stuff, I would probably create another environment, docs-opt, and allow failures until we have a good feel for whether it should be a hard fail, just for info, or dropped from the CI run.

I think that would be a good start because it's better than our simple make doctest html epub Sphinx builders.

Let me know your thoughts.

@mmerickel
Copy link
Member

mmerickel commented Aug 21, 2018

@stevepiercy my interest would be in maintaining syntax consistency more than anything related to spelling/grammar. We can leave that for a separate PR but I think it's important if you want to start enforcing these things that they be automated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants