Add support for having no expiry on a cache region. #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -165,6 +167,8 @@ def set_cache_regions_from_settings(settings): | |||
| for key in list(cache_settings.keys()): | |||
| if key.startswith(region_prefix): | |||
| region_settings[key[region_len:]] = cache_settings.pop(key) | |||
| if region_settings['expire'] == 'None': | |||
There was a problem hiding this comment.
If this is to be added it should be a little more lenient than simply passing None. At least make it case-insensitive, but perhaps also accept no.
There was a problem hiding this comment.
Done! I also added a unit test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now setting e.g.,
cache.expire = Noneresults in an exception because it's interpreted as a string. This fixes it.