lint: correct flake8 B017 with specific exceptions #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using more specific exceptions is useful to ensure that another, unexpected exception isn't raised during testing. Refs: https://github.com/PyCQA/flake8-bugbear#list-of-warnings Signed-off-by: Mike Fiedler <miketheman@gmail.com>
miketheman
commented
Nov 20, 2024
| @@ -279,7 +279,7 @@ def test_request_make_body_seekable_cleans_up_threadmanger_on_exception( | |||
| assert len(manager.stack) == 0 | |||
| app = config.make_wsgi_app() | |||
| app = webtest.TestApp(app) | |||
| with pytest.raises(Exception): | |||
| with pytest.raises(IOError): | |||
There was a problem hiding this comment.
I selected IOError here as that's the ancestor for webob.request.DisconnectionError
|
@mmerickel Any chance you've got time to review this, and maybe some others here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using more specific exceptions is useful to ensure that another, unexpected exception isn't raised
during testing.
Refs: https://github.com/PyCQA/flake8-bugbear#list-of-warnings