addressing ZODB/issues/12, encode request.path_infobefore passing it to transaction.note

[yentsun]

As discussed in zopefoundation/ZODB#12 I too have unicode urls in my project and this issue blocks me when I try to update a context object with unicode in path_info

File "/home/chao/projs/venvpython2/local/lib/python2.7/site-packages/ZODB-4.0.0-py2.7.egg/ZODB/FileStorage/format.py", line 287, in asString
    return b"".join(map(as_bytes, [s, self.user, self.descr, self.ext]))
  File "/home/chao/projs/venvpython2/local/lib/python2.7/site-packages/ZODB-4.0.0-py2.7.egg/ZODB/utils.py", line 75, in as_bytes
    return str(obj)
UnicodeEncodeError: 'ascii' codec can't encode characters in position 32-34: ordinal not in range(128)

This update of mine fixes the problem, though I'm not sure if I didn't break anything else.

[yentsun]

Sorry I haven't run the tests. I guess my fix breaks Python 3 compatibility...

[tseaver]

This probably needs something like the pyramid.compat.text_ function.

[yentsun]

Thanks for the pointing, Tres. I made it with pyramid.compat.bytes_ instead. I also added one test for the unicode path_info case.

[yentsun]

ok, I'll add if PY3 check...

[yentsun]

Can someone point me if I need to improve the patch. Is it too naive? I really want to contribute!

[tseaver]

Can't this just use pyramid.compat.bytes_? That function already handles the if PY3: case correctly, and its name makes it clear that you mean to be passing bytes to t.note().

[yentsun]

It was done initially in commit d902b85, but it failed tests in py3 environment. To be honest - I am not qualified enough in py3, so I moved the call under if check. But I got your point, I'll try to remove extra check and function call...

[tseaver]

OK, I've looked at it: Transaction.note() requires a native string (not bytes as I first thought). Fortunately, the transaction package provides a helper for that:

from transaction._compat import native_
#...
    t.note(native_(request.path_info))

That would allow us to drop the changes to pyramid_tm/compat.py.

We do need to add a test which exercises this behavior: one each passing unicode and bytes to `tm_tween'.

[yentsun]

Tres, please review. I didn't manage to avoid PY3 check in one of the tests I've added, but I hope its acceptable. Sorry for the commit spam - I don't have py3 env and relied on Travis output.

[tseaver]

Thank you!

[yentsun]

Thank you for quick response!