Make annotating the transaction with user optional #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Warehouse I have the the AuthenticationPolicy's adding a
Vary: Cookieso that any access to the user ensures that we make the response varied by cookie. We do this because we assume that if you're accessing the user you're going to do something different based on that information and we need to vary it.This however doesn't work because pyramid_tm assumes it can access
request.unauthenticated_useron every request to annotate the transaction with a particular user. I don't believe I need this functionality in Warehouse so I'd love a knob to turn off that behavior.