Skip to content

Commit

Permalink
Let the functional tests hang rather than killing off the subprocess
Browse files Browse the repository at this point in the history
  • Loading branch information
kgaughan committed Oct 29, 2024
1 parent ba83320 commit 1b6bbcd
Showing 1 changed file with 3 additions and 7 deletions.
10 changes: 3 additions & 7 deletions tests/test_functional.py
Original file line number Diff line number Diff line change
Expand Up @@ -97,11 +97,8 @@ def stop_subprocess(self):
self.proc.terminate()
self.sock.close()
# This give us one FD back ...
self.proc.join(timeout=5)
if self.proc.is_alive():
self.proc.terminate()
else:
self.proc.close()
self.proc.join()
self.proc.close()
self.queue.close()
self.queue.join_thread()

Expand Down Expand Up @@ -166,10 +163,9 @@ def test_it(self):
time.sleep(3)

for proc in procs:
proc.poll()
if proc.returncode is not None: # pragma: no cover
proc.terminate()
proc.wait(timeout=5)
proc.wait()
# the notsleepy response should always be first returned (it sleeps
# for 2 seconds, then returns; the notsleepy response should be
# processed in the meantime)
Expand Down

0 comments on commit 1b6bbcd

Please sign in to comment.