Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs,tests: update contributing running tests section #470

Merged
merged 4 commits into from
Oct 24, 2024
Merged

docs,tests: update contributing running tests section #470

merged 4 commits into from
Oct 24, 2024

Conversation

miketheman
Copy link
Contributor

@miketheman
docs: update contributing running tests section
0683e3f 
- Remove Python 2.x instructions
- Use correct modern targets

Signed-off-by: Mike Fiedler <miketheman@gmail.com>
@miketheman
test: record test contexts to output
f6dbb20 
- Enable contexts display in HTML reports

Refs: https://pytest-cov.readthedocs.io/en/stable/contexts.html

Signed-off-by: Mike Fiedler <miketheman@gmail.com>
stevepiercy
stevepiercy requested changes Oct 18, 2024
View reviewed changes
Copy link
Member

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specify shell syntax.

contributing.md Outdated Show resolved Hide resolved
contributing.md Outdated Show resolved Hide resolved
@miketheman @stevepiercy
Apply suggestions from code review
ee560f5 
Co-authored-by: Steve Piercy <web@stevepiercy.com>
stevepiercy
stevepiercy requested changes Oct 19, 2024
View reviewed changes
Copy link
Member

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With these changes, I approve the docs.

contributing.md Outdated Show resolved Hide resolved
contributing.md Outdated Show resolved Hide resolved
contributing.md Outdated Show resolved Hide resolved
@miketheman @stevepiercy
Apply suggestions from code review
ae5b26f 
Co-authored-by: Steve Piercy <web@stevepiercy.com>
stevepiercy
stevepiercy approved these changes Oct 19, 2024
View reviewed changes
Copy link
Member

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs look good. The rest should be reviewed by a core maintainer. Thank you!

@digitalresistor
Copy link
Member

This is great, thanks!

@digitalresistor digitalresistor merged commit c5a80e5 into Pylons:main Oct 24, 2024
22 checks passed
@miketheman miketheman deleted the miketheman/contributing branch October 24, 2024 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevepiercy stevepiercy stevepiercy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miketheman @digitalresistor @stevepiercy