Add RuntimeError for stale non-anticipative variables on feasible scenarios #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Give me day to look into interaction with probability zero variables. |
Good catch. I think we need to allow those to pass, as they will likely be stale (but should have a |
|
@DLWoodruff I think I fixed this for zero-probability variables. Maybe the error message for that case could be improved -- I think they still need to have a non-None |
DLWoodruff
approved these changes
Oct 28, 2021
bknueven
commented
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #170. Given that the solve need to touch every variable at least once when loading it into the model, this safety check on only the nonanticipative variables once per solve should not be onerous.