Making hub and spoke dict callback a function of the model module instead of a separate module #499
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think having the callback that does hub and spoke dict manipulation in
generic_cylinders.pyas a function within the model module is more convenient because that manipulation can be dependent on the value of the config optionscfg. The same could be achieved by just also passingcfgto the callback the way it is written now but in the case where the user defines a class within their model module, having the callback be a method of the class makescfg-dependent implementation straightforward.