-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Pyomo.DOE logo files #2527
Conversation
@jialuw96 the logo is on this branch for future presentations, etc. |
Not merging! Just approving to streamline merging later. |
Converting this to draft/WIP until the Pyomo.DOE PR is merged |
@blnicho @kaklise @jsiirola @mrmundt @jialuw96 We now have two versions of the logo. Files for both are on GitHub (in folders named version 1 and 2 in this draft PR). Once we decide which one to keep, I'll delete the other one. We'll then have the not used version saved in GitHub history. I like version 2. I agree with @jsiirola that "DOE" may be confused with "Department of Energy". The only downside is that the official paper has "Pyomo.DOE" in the title. IMO, that is not enough to warrant sticking with version 1. Happy to hear comments from others. |
I just finished editing a presentation and I prefer version 2 (Pyomo.DoE). @jialuw96 any thoughts on referring to our package as Pyomo.DoE? |
I am okay with this change. |
@adowling2 @jialuw96 I think the consensus was to go with version 2 of the logo, "Pyomo.DoE". Can you remove version 1 from this PR? Once that's done this will be ready to merge. |
Yes, I'll have this ready in 10 minutes. |
Now let's see if this breaks the documentation. |
@adowling2 looks like the logo was not included in the readthedocs documentation in #2294 so there is nothing to break. Do you plan to add it as part of this PR or add it as another task under #2610? |
I say merge this and then a separate PR. |
Codecov ReportBase: 84.97% // Head: 86.79% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2527 +/- ##
==========================================
+ Coverage 84.97% 86.79% +1.82%
==========================================
Files 766 766
Lines 86041 86041
==========================================
+ Hits 73113 74679 +1566
+ Misses 12928 11362 -1566
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Fixes (none)
Please do not merge until #2294 has been merged.
Summary/Motivation:
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: