Fix PyROS UncertaintySet.bouding_problem Method
#2659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
blnicho
reviewed
Dec 7, 2022
| @@ -348,7 +348,7 @@ def parameter_bounds(self): | |||
| """ | |||
| raise NotImplementedError | |||
|
|
|||
| def bounding_model(self): | |||
| def bounding_model(self, config=None): | |||
There was a problem hiding this comment.
You should describe this new argument in the docstring
There was a problem hiding this comment.
See subsequent commit
blnicho
approved these changes
Dec 7, 2022
jsiirola
approved these changes
Dec 7, 2022
Codecov ReportBase: 87.06% // Head: 87.06% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2659 +/- ##
=======================================
Coverage 87.06% 87.06%
=======================================
Files 757 757
Lines 84293 84293
=======================================
+ Hits 73386 73389 +3
+ Misses 10907 10904 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary/Motivation:
The method
pyros.UncertaintySet.bounding_modelmay require access to the subordinate global optimizer passed to the PyROS solver, depending on the type of the uncertainty set passed to the solver. In particular, this requirement holds for the PyROSIntersectionSet.Changes proposed in this PR:
configargument toUncertaintySet.bounding_problem.IntersectionSet.Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: