Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test for QCQO #2682

Merged
merged 3 commits into from
Jan 11, 2023
Merged

Unit test for QCQO #2682

merged 3 commits into from
Jan 11, 2023

Conversation

Utkarsh-Detha
Copy link
Contributor

Change

  • Added a small unit test for QCQO problems for Pyomo-MOSEK.

( I did not want to obfuscate the purpose of #2647, so I made this a separate PR)

Summary/Motivation:

A while ago there was a bug due to mosek_direct passing upper-triangular elements when setting Q matrix elements. This was fixed, but no unit test was added for this. That has been changed.

Changes proposed in this PR:

  • Unit test (small qcqo problem).

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@Utkarsh-Detha Utkarsh-Detha changed the title Small fixes Unit test for QCQO Jan 3, 2023
@emma58 emma58 requested a review from jsiirola January 3, 2023 19:36
@jsiirola
Copy link
Member

jsiirola commented Jan 5, 2023

(Note, this includes #2647, so merging this will merge/close both)

@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Base: 81.67% // Head: 87.06% // Increases project coverage by +5.39% 🎉

Coverage data is based on head (6d6136a) compared to base (7b1c396).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2682      +/-   ##
==========================================
+ Coverage   81.67%   87.06%   +5.39%     
==========================================
  Files         757      757              
  Lines       84510    84511       +1     
==========================================
+ Hits        69025    73582    +4557     
+ Misses      15485    10929    -4556     
Flag Coverage Δ
linux 84.50% <0.00%> (?)
osx 74.54% <0.00%> (?)
other 84.68% <0.00%> (?)
win 81.84% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyomo/solvers/plugins/solvers/mosek_direct.py 67.88% <100.00%> (+0.29%) ⬆️
pyomo/core/expr/visitor.py 93.40% <0.00%> (+0.15%) ⬆️
pyomo/repn/plugins/nl_writer.py 85.89% <0.00%> (+0.16%) ⬆️
pyomo/repn/plugins/ampl/ampl_.py 86.20% <0.00%> (+0.19%) ⬆️
pyomo/solvers/plugins/solvers/GAMS.py 67.90% <0.00%> (+0.24%) ⬆️
pyomo/contrib/interior_point/interior_point.py 95.03% <0.00%> (+0.26%) ⬆️
pyomo/solvers/plugins/solvers/xpress_direct.py 72.82% <0.00%> (+0.30%) ⬆️
pyomo/contrib/appsi/solvers/cbc.py 82.79% <0.00%> (+0.32%) ⬆️
pyomo/contrib/appsi/solvers/ipopt.py 88.85% <0.00%> (+0.33%) ⬆️
... and 101 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jsiirola jsiirola merged commit 5c4fee8 into Pyomo:main Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants