Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDPOpt: Switching a LBB test to use Gurobi as MINLP solver #2686

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

emma58
Copy link
Contributor

@emma58 emma58 commented Jan 10, 2023

Fixes current GDPopt test failure after BARON released 23.1.5

Summary/Motivation:

BARON 23.1.5 is returning a wrong answer during gdpopt.lbb, causing it to converge to the wrong solution. This switches the test to use Gurobi for now because it's quadratic anyway...

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

…ic) because BARON 23.1.5 seems to be giving the wrong answer...
@emma58 emma58 mentioned this pull request Jan 10, 2023
@bernalde
Copy link
Contributor

I would suggest also making the problem instance available to MINLP.com as finding bugs in BARON gives you a badge of honor with Nick.

@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Base: 87.06% // Head: 87.07% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (3bf9f8c) compared to base (8f7174f).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2686   +/-   ##
=======================================
  Coverage   87.06%   87.07%           
=======================================
  Files         757      757           
  Lines       84503    84503           
=======================================
+ Hits        73573    73577    +4     
+ Misses      10930    10926    -4     
Flag Coverage Δ
linux 84.51% <ø> (+<0.01%) ⬆️
osx 74.54% <ø> (ø)
other 84.69% <ø> (ø)
win 81.84% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyomo/contrib/mindtpy/iterate.py 81.36% <0.00%> (+1.81%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jsiirola jsiirola merged commit 075bd18 into Pyomo:main Jan 10, 2023
@emma58 emma58 deleted the fix-gdpopt-failure branch February 15, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants