Fix handling of POW in Baron writer #2693
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Summary/Motivation:
@shermanjasonaf noted a bug in the Baron writer where expressions of the form "m.x ** (c + m.p * m.y)" where m.p is a mutable Param with value 0 would be written to the BAR file as "x ^ (3 + 0*y)", which is not legal (Baron sees the right argument as variable).
This PR resolves the issue by re-evaluating fixed arguments to resolve them to numeric constants, and adds tests exercising this edge case,
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: