Change GAMS solver type for time limit adjustment #2706
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary/Motivation:
The PyROS subsolver time limit adjustment routine introduced in #2660 does not properly detect the GAMS shell solver type (
solvers.plugins.solvers.GAMS.GAMSShell
ortype(SolverFactory("gams", solver_io="shell"))
, for which the routine was originally written. This detection issue occurs as the GAMS shell solver type does not inherit from the generic GAMS solver interface typesolvers.plugins.solvers.GAMS.GAMSSolver
(accessed viaSolverFactory.get_class("gams")
).In this PR, we ensure that the GAMS shell type, rather than the more generic interface, is detected
and acted upon in the subsolver time limit adjustment routine of #2660.
Changes proposed in this PR:
See summary.
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: