Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pyomo --version version string #2743

Merged
merged 4 commits into from
Feb 16, 2023
Merged

Conversation

jsiirola
Copy link
Member

Fixes # .

Summary/Motivation:

#2741 requests that developers set the version= parameter to the development version returned by pyomo --version. This PR fixes pyomo --version so that the full __version__ is printed out (including the .dev0).

This also cleans up some of the logic around the version system, adding a little documentation, and removing support for development in Subversion (which we haven't supported in more than 4 years).

Changes proposed in this PR:

  • include the development serial number in pyomo --version
  • clean up logic in pyomo/version/info.py

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Base: 86.80% // Head: 86.73% // Decreases project coverage by -0.07% ⚠️

Coverage data is based on head (7defe56) compared to base (0f59de9).
Patch coverage: 80.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2743      +/-   ##
==========================================
- Coverage   86.80%   86.73%   -0.07%     
==========================================
  Files         774      774              
  Lines       86980    86984       +4     
==========================================
- Hits        75499    75444      -55     
- Misses      11481    11540      +59     
Flag Coverage Δ
linux 83.80% <80.00%> (-0.01%) ⬇️
osx 73.27% <80.00%> (+<0.01%) ⬆️
other 83.98% <80.00%> (-0.01%) ⬇️
win 81.20% <80.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyomo/version/info.py 78.12% <80.00%> (-0.45%) ⬇️
pyomo/util/subsystems.py 89.13% <0.00%> (-8.70%) ⬇️
...ontrib/appsi/utils/collect_vars_and_named_exprs.py 93.75% <0.00%> (-6.25%) ⬇️
pyomo/core/base/external.py 95.43% <0.00%> (-3.16%) ⬇️
pyomo/contrib/appsi/writers/nl_writer.py 84.39% <0.00%> (-2.32%) ⬇️
pyomo/repn/plugins/ampl/ampl_.py 81.40% <0.00%> (-1.86%) ⬇️
pyomo/core/expr/compare.py 96.52% <0.00%> (-1.74%) ⬇️
pyomo/contrib/mindtpy/algorithm_base_class.py 80.79% <0.00%> (-0.34%) ⬇️
pyomo/contrib/appsi/solvers/ipopt.py 88.51% <0.00%> (-0.34%) ⬇️
pyomo/repn/plugins/nl_writer.py 93.62% <0.00%> (-0.32%) ⬇️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@blnicho blnicho merged commit b7ca8d5 into Pyomo:main Feb 16, 2023
@jsiirola jsiirola deleted the fix-version-string branch March 3, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants