-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contrib.piecewise: Adding transformation to outer representation GDP #2766
Conversation
… base class that all the PW to GDP transformations can use.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2766 +/- ##
=======================================
Coverage 87.00% 87.01%
=======================================
Files 758 761 +3
Lines 86991 87057 +66
=======================================
+ Hits 75690 75751 +61
- Misses 11301 11306 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR. WIth the right framework of GDP, "advanced" formulations such as the PWL one from VIelma become easily implementable. I found a couple places where I had questions, but overall this is really great :)
…choice model from our multiple choice transformation
@jsiirola, this is ready to look at again. |
Fixes # .
Summary/Motivation:
This adds a transformation from a model containing PiecewiseLinearFunctions to a GDP where the domains underlying each piece of the piecewise linear function are represented using an "outer" (Ax <= b) representation. This allows for a wrapper transformation to create the multiple choice formulation from Vielma et al. 2010.
NOTE: this includes the changes in #2708, so it will be easier to review once that is merged.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: