contrib.piecewise: Fixing a bug caused by degenerate simplices #2797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing a DeveloperError when it appears that failed, warning user about points dropped in the triangulation
emma58
changed the title
…ion, which means that later sorting the simplices means something.
…ices inside of each of the 8 cubes of the grid.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2797 +/- ##
=======================================
Coverage 87.01% 87.01%
=======================================
Files 763 763
Lines 87213 87229 +16
=======================================
+ Hits 75886 75901 +15
- Misses 11327 11328 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
…ck of where to place the blame and throwing either a ValueError or DeveloperError accordingly.
mrmundt
approved these changes
Apr 11, 2023
| @@ -30,6 +33,8 @@ | |||
| # be zero. | |||
| ZERO_TOLERANCE = 1e-8 | |||
|
|
|||
| logger = logging.getLogger('contrib.piecewise') | |||
There was a problem hiding this comment.
We love logging. Yes, we do.
jsiirola
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Summary/Motivation:
When we construct a
PiecewiseLinearFunctionfrom a set of points, a lot of times users will give us a grid. This means that the Delaunay triangulation is quite degenerate, so we get a lot of degenerate simplices back. This PR adds a check after calling the triangulation to filter out all simplices that are not full-dimensional.Changes proposed in this PR:
scipy.spatial.Delaunayand keep only full-dimensional onesDeveloperErrorwhen the linear system solve to find the hyperplane above a simplex is unexpectedly singular: this is a sign that we didn't correctly filter out degenerate simplices (in particular, it's possible we'll need a tolerance rather than keeping anything with a determinant that's not exactly 0.)Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: