Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version of crate-ci/typos GitHub Actions #2869

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

mrmundt
Copy link
Contributor

@mrmundt mrmundt commented Jun 9, 2023

Fixes NA

Summary/Motivation:

There was a new version of the crate-ci/typos Action that we use that integrates some new common misspellings. This PR addresses those.

Changes proposed in this PR:

  • New typo fixes!
  • Ignore some things that aren't typos

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@mrmundt mrmundt requested a review from blnicho June 9, 2023 22:07
@@ -27,6 +27,7 @@


from pyomo.common.dependencies import numpy as np, pandas as pd, matplotlib as plt
from pyomo.core.expr.numvalue import value
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems unused in the new changes. Is this necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, this is a sneaky bug fix. When I opened this file, my IDE started yelling loudly that value was used but never imported. (Also indicates that we have untested code in here - not good!)

Copy link

@tlhoeve tlhoeve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Patch coverage: 33.33% and no project coverage change.

Comparison is base (afc9ee5) 87.48% compared to head (fcdf25c) 87.48%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2869   +/-   ##
=======================================
  Coverage   87.48%   87.48%           
=======================================
  Files         771      771           
  Lines       89597    89598    +1     
=======================================
+ Hits        78380    78383    +3     
+ Misses      11217    11215    -2     
Flag Coverage Δ
linux 84.55% <33.33%> (+<0.01%) ⬆️
osx 74.60% <11.11%> (+<0.01%) ⬆️
other 84.72% <33.33%> (+<0.01%) ⬆️
win 82.12% <33.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyomo/common/timing.py 92.18% <ø> (ø)
...omo/contrib/piecewise/piecewise_linear_function.py 96.44% <ø> (ø)
...contrib/preprocessing/plugins/induced_linearity.py 94.76% <0.00%> (ø)
...mo/contrib/preprocessing/plugins/var_aggregator.py 97.39% <ø> (ø)
pyomo/contrib/viewer/model_browser.py 90.00% <ø> (ø)
pyomo/core/base/connector.py 90.97% <ø> (ø)
pyomo/core/base/set.py 99.35% <ø> (ø)
pyomo/dataportal/DataPortal.py 94.96% <ø> (ø)
pyomo/network/foqus_graph.py 90.30% <ø> (ø)
pyomo/scripting/plugins/build_ext.py 71.73% <ø> (ø)
... and 3 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@blnicho blnicho merged commit 5e16a1b into Pyomo:main Jun 12, 2023
@mrmundt mrmundt deleted the new-typos-version branch July 25, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants