-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New version of crate-ci/typos
GitHub Actions
#2869
Conversation
@@ -27,6 +27,7 @@ | |||
|
|||
|
|||
from pyomo.common.dependencies import numpy as np, pandas as pd, matplotlib as plt | |||
from pyomo.core.expr.numvalue import value |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems unused in the new changes. Is this necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, this is a sneaky bug fix. When I opened this file, my IDE started yelling loudly that value
was used but never imported. (Also indicates that we have untested code in here - not good!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2869 +/- ##
=======================================
Coverage 87.48% 87.48%
=======================================
Files 771 771
Lines 89597 89598 +1
=======================================
+ Hits 78380 78383 +3
+ Misses 11217 11215 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Fixes NA
Summary/Motivation:
There was a new version of the
crate-ci/typos
Action that we use that integrates some new common misspellings. This PR addresses those.Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: