-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interfaces to the SAS solvers #2886
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR! Overall, it looks good; however, we do not (as far as I am aware) have SAS in our testing environment. I will approve GitHub Actions to run for this PR to confirm.
Please look at the two test_*.yml
files in https://github.com/Pyomo/pyomo/tree/main/.github/workflows
Confirmed my previous comment: https://github.com/Pyomo/pyomo/actions/runs/5374476640/jobs/9760403183?pr=2886#step:24:8439 <- SAS tests are skipped. |
Too bad, I was hoping you might have an academic version of at least SAS 9.4 available somewhere. I ran the unit tests with various SAS versions in my environment, is this good enough for you? |
Unfortunately, no. Because this PR proposes adding the solver into the core offering of Pyomo, we need to ensure its capabilities on our various Python and OS versions before it can be merged. If you have information on how we might go about obtaining an academic license, we are willing to pursue that. |
I will investigate how to most easily give you a license or access to machines that run SAS. I'll get back to you as soon as I hear something. Which institution would a license be for? |
Thank you! The primary developers are at Sandia National Laboratories, so likely there. Please feel free to email wg-pyomo@sandia.gov so we can discuss further. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2886 +/- ##
==========================================
- Coverage 87.83% 87.59% -0.24%
==========================================
Files 770 771 +1
Lines 89642 89976 +334
==========================================
+ Hits 78733 78814 +81
- Misses 10909 11162 +253
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Good news, @phchri ! We have SAS approval for our test machines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found a few small typos in comments and one in an error message but otherwise this looks good.
Fixes
Provides an interface to the SAS LP/MILP optimization solvers.
Summary/Motivation:
Provides an interface to the SAS LP/MILP optimization solvers on both the legacy 9.4 platform (via the saspy package) and on the SAS Viya cloud platform (CAS, via the swat package).
I'm repurposing the solver_io option to choose between the two interfaces, if there is a better way to do this, please advise. The idea is that the interface chooses automatically depending on which package is available.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: